Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stopgap for BigNumber shift NaN issue #24691

Merged
merged 1 commit into from
May 21, 2024
Merged

Conversation

dbrans
Copy link
Contributor

@dbrans dbrans commented May 21, 2024

Description

Stopgap for #24690

Open in GitHub Codespaces

Related issues

Related: #24690 – do not close this.

Manual testing steps

  1. Try to reproduce [Bug]: error "BigNumber shift integer NaN" in simulation details #24690

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've completed the PR template to the best of my ability
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@dbrans dbrans changed the title stopgap for BigNumber shift NaN issue fix: stopgap for BigNumber shift NaN issue May 21, 2024
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@dbrans dbrans added the team-transactions Transactions team label May 21, 2024
@dbrans dbrans marked this pull request as ready for review May 21, 2024 17:11
@dbrans dbrans requested review from a team as code owners May 21, 2024 17:11
@sleepytanya
Copy link
Contributor

I can't reproduce the bug on current branch:
https://jam.dev/c/d806d500-f4a7-4b84-80b9-e439bba8aa45

@metamaskbot
Copy link
Collaborator

Builds ready [5d1a276]
Page Load Metrics (1073 ± 592 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint64154992512
domContentLoaded9371563
load52279110731234592
domInteractive9371563
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: -11 Bytes (-0.00%)
  • common: 0 Bytes (0.00%)

@dbrans dbrans merged commit 4233f9e into develop May 21, 2024
79 of 80 checks passed
@dbrans dbrans deleted the dbrans/fix-decimals branch May 21, 2024 19:47
@github-actions github-actions bot locked and limited conversation to collaborators May 21, 2024
@metamaskbot metamaskbot added release-11.18.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 and removed release-11.18.0 labels May 21, 2024
@metamaskbot
Copy link
Collaborator

Missing release label release-11.16.0 on PR. Adding release label release-11.16.0 on PR and removing other release labels(release-11.18.0), as PR was cherry-picked in branch 11.16.0.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.16.0 Issue or pull request that will be included in release 11.16.0 team-transactions Transactions team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants