Snapshot txMeta without cloning history (#8363)

MetaMask · Apr 20, 2020 · a83d264 · a83d264
1 parent 7c3ffeb
commit a83d264
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/app/scripts/controllers/transactions/lib/tx-state-history-helper.js b/app/scripts/controllers/transactions/lib/tx-state-history-helper.js
@@ -62,13 +62,12 @@ function replayHistory (_shortHistory) {
 }
 
 /**
-  @param {Object} txMeta
-  @returns {Object} - a clone object of the txMeta with out history
-*/
+ * Snapshot {@code txMeta}
+ * @param {Object} txMeta - the tx metadata object
+ * @returns {Object} a deep clone without history
+ */
 function snapshotFromTxMeta (txMeta) {
-  // create txMeta snapshot for history
-  const snapshot = cloneDeep(txMeta)
-  // dont include previous history in this snapshot
-  delete snapshot.history
-  return snapshot
+  const shallow = { ...txMeta }
+  delete shallow.history
+  return cloneDeep(shallow)
 }