[Bug]: Polygon conversion amount inconsistent along the Send ERC20 flow with no units #20106
Assignees
Labels
Comments
seaona
added
type-bug
team-confirmations-secure-ux
|
Thanks |
bschorchit
added
the
Sev2-normal
bschorchit
added
team-confirmations-planning
This was referenced Oct 4, 2023
sahar-fehri
added a commit
that referenced
this issue
Oct 11, 2023
## **Description** This PR fixes one part of the bug shown in this github issue: #20106 When you try to send a token on polygon network and you are on the confirmation page; it shows the value of matic without a unit not an icon to indicate the network. If you are on ethereum network and you try to send an ERC20, it shows ethereum icon. In this PR i am using the AvatarNetwork component that is used on the main tokens page to indicate the network of tokens. ## **Manual testing steps** _1. Switch to polygon _2. Choose an ERC20 token and click send. _3. Add amount in amount input and click confirm and notice there is no unit/network icon displayed ## **Screenshots/Recordings** _If applicable, add screenshots and/or recordings to visualize the before and after of your change._ ### **Before** Ethereum:  Polygon  BNB  ### **After** Ethereum:  Polygon:  BNB:  ## **Related issues** [_Fixes #MMASSETS-26](https://consensyssoftware.atlassian.net/browse/MMASSETS-26) ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
sahar-fehri
added a commit
that referenced
this issue
Oct 13, 2023
## **Description** This PR solves one bug shown in this github issue: #20106 When you try to send a token, on Polygon, it does not show the conversion of the amount, it just shows "ETH". If you chose "FIAT" in the settings=>general, this issue does not occur. This only happens when you choose crypto. PS: I have also noticed this issue on BNB chain. On Ethereum network, all works fine. If you try to send a token on other chains, you won't be able to see the conversion correctly and it will always just show "ETH". ## **Manual testing steps** _1. Chose polygon network _2. Go to settings => General and choose "MATIC" as the primary currency. _3. Go back to the home screen and choose a token to send (exp USDC) _4. Click on the "send" button and choose an account _5. Notice that if you type "5" in the amount input, you will see "ETH" as the conversion of that amount. (The same steps are applicable on BNB chain) ## **Screenshots/Recordings** _If applicable, add screenshots and/or recordings to visualize the before and after of your change._ ### **Before** On Polygon  On BNB  ### **After** On Polygon:  On BNB:  ## **Related issues** (_Fixes #MMASSETS-26)[https://consensyssoftware.atlassian.net/browse/MMASSETS-26] ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
k-g-j
pushed a commit
that referenced
this issue
Nov 1, 2023
## **Description** This PR fixes one part of the bug shown in this github issue: #20106 When you try to send a token on polygon network and you are on the confirmation page; it shows the value of matic without a unit not an icon to indicate the network. If you are on ethereum network and you try to send an ERC20, it shows ethereum icon. In this PR i am using the AvatarNetwork component that is used on the main tokens page to indicate the network of tokens. ## **Manual testing steps** _1. Switch to polygon _2. Choose an ERC20 token and click send. _3. Add amount in amount input and click confirm and notice there is no unit/network icon displayed ## **Screenshots/Recordings** _If applicable, add screenshots and/or recordings to visualize the before and after of your change._ ### **Before** Ethereum:  Polygon  BNB  ### **After** Ethereum:  Polygon:  BNB:  ## **Related issues** [_Fixes #MMASSETS-26](https://consensyssoftware.atlassian.net/browse/MMASSETS-26) ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [x] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
k-g-j
pushed a commit
that referenced
this issue
Nov 1, 2023
## **Description** This PR solves one bug shown in this github issue: #20106 When you try to send a token, on Polygon, it does not show the conversion of the amount, it just shows "ETH". If you chose "FIAT" in the settings=>general, this issue does not occur. This only happens when you choose crypto. PS: I have also noticed this issue on BNB chain. On Ethereum network, all works fine. If you try to send a token on other chains, you won't be able to see the conversion correctly and it will always just show "ETH". ## **Manual testing steps** _1. Chose polygon network _2. Go to settings => General and choose "MATIC" as the primary currency. _3. Go back to the home screen and choose a token to send (exp USDC) _4. Click on the "send" button and choose an account _5. Notice that if you type "5" in the amount input, you will see "ETH" as the conversion of that amount. (The same steps are applicable on BNB chain) ## **Screenshots/Recordings** _If applicable, add screenshots and/or recordings to visualize the before and after of your change._ ### **Before** On Polygon  On BNB  ### **After** On Polygon:  On BNB:  ## **Related issues** (_Fixes #MMASSETS-26)[https://consensyssoftware.atlassian.net/browse/MMASSETS-26] ## **Pre-merge author checklist** - [x] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [x] I've clearly explained: - [x] What problem this PR is solving. - [x] How this problem was solved. - [x] How reviewers can test my changes. - [x] I’ve indicated what issue this PR is linked to: Fixes #??? - [x] I’ve included tests if applicable. - [x] I’ve documented any added code. - [x] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). - [ ] I’ve properly set the pull request status: - [ ] In case it's not yet "ready for review", I've set it to "draft". - [ ] In case it's "ready for review", I've changed it from "draft" to "non-draft". ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.
|
Bug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
Problem: whenever i am sending a transaction from Polygon network, I can see how on the confirmation screen there is a conversion value that I don't know what it is.
Furthermore, on the Asset screen, I see no conversion, only
ETHbelow the value.polygon-tx.mp4
Steps to reproduce
ETHbelow without any valueError messages or log output
No response
Version
10.33.1 prod
Build type
None
Browser
Chrome
Operating system
Linux
Hardware wallet
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: