fix: display conversion rate #21185

sahar-fehri · 2023-10-04T08:49:20Z

Description

This PR solves one bug shown in this github issue: #20106

When you try to send a token, on Polygon, it does not show the conversion of the amount, it just shows "ETH".

If you chose "FIAT" in the settings=>general, this issue does not occur. This only happens when you choose crypto.

PS: I have also noticed this issue on BNB chain. On Ethereum network, all works fine. If you try to send a token on other chains, you won't be able to see the conversion correctly and it will always just show "ETH".

Manual testing steps

_1. Chose polygon network
_2. Go to settings => General and choose "MATIC" as the primary currency.
_3. Go back to the home screen and choose a token to send (exp USDC)
_4. Click on the "send" button and choose an account
_5. Notice that if you type "5" in the amount input, you will see "ETH" as the conversion of that amount.

(The same steps are applicable on BNB chain)

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change.

Before

On Polygon

On BNB

After

On Polygon:

On BNB:

Related issues

(_Fixes #MMASSETS-26)[https://consensyssoftware.atlassian.net/browse/MMASSETS-26]

Pre-merge author checklist

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

github-actions · 2023-10-04T08:49:34Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

sahar-fehri · 2023-10-04T09:05:51Z

ui/components/ui/token-input/token-input.component.js

-      // Display ETH
-      currency = EtherDenomination.ETH;
+      // Display Native currency
+      currency = nativeCurrency;


Here we notice this piece of code if(showFiat){....} else{ fallback to ETH} . When you set Fiat in the settings=>General, the problem does not occur.
When you choose crypto, it falls back automatically to 'display ETH' and currency is currency = EtherDenomination.ETH;
regardless of the network you are on.

On the core repo; inside TokenRatesController.ts there is this fct fetchAndMapExchangeRates responsible for fetching the conversion rates. That function first checks if the nativeCurrencySupported by coingecko which in the case of BNB returns true and in the case of "MATIC" returns false.

If it is supported it will return the prices from coingecko, if it is not; it will
1- fetch from coingecko the exchange rate of that token exp (USDC) against the fallback currency (eth)
2- fetch from cryptocompare the conversion of native currency exp (ETH) vs(MATIC)

And then eventually it will multiply them tokenToVsCurrencyConversionRate * vsCurrencyToNativeCurrencyConversionRate returning the conversion of USDC in the native currency (MATIC).

metamaskbot · 2023-10-04T10:42:15Z

Builds ready [888715c]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (535 ± 321 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	145	100	17	8
		domContentLoaded	69	140	91	21	10
		load	82	1795	535	669	321
		domInteractive	69	139	91	21	10

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 199 Bytes (0.00%)
common: 0 Bytes (0.00%)

metamaskbot · 2023-10-04T12:36:35Z

Builds ready [fbf94bb]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (359 ± 259 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	83	117	93	11	5
		domContentLoaded	67	106	85	12	6
		load	78	1471	359	540	259
		domInteractive	67	106	85	12	6

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 199 Bytes (0.00%)
common: 0 Bytes (0.00%)

codecov · 2023-10-04T12:37:13Z

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (a4e2610) 68.64% compared to head (52c4561) 68.64%.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #21185   +/-   ##
========================================
  Coverage    68.64%   68.64%           
========================================
  Files         1017     1017           
  Lines        40797    40797           
  Branches     10893    10893           
========================================
  Hits         28004    28004           
  Misses       12793    12793

Files	Coverage Δ
...components/ui/token-input/token-input.component.js	`91.07% <100.00%> (ø)`
...components/ui/token-input/token-input.container.js	`100.00% <ø> (ø)`

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

metamaskbot · 2023-10-09T13:46:10Z

Builds ready [52c4561]

builds: chrome, firefox
builds (beta): chrome
builds (flask): chrome, firefox
builds (MMI): chrome, firefox
builds (test): chrome, firefox
builds (test-flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (784 ± 374 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	81	137	97	14	7
		domContentLoaded	69	135	88	18	8
		load	77	2007	784	779	374
		domInteractive	69	135	88	18	8

Bundle size diffs

background: 0 Bytes (0.00%)
ui: 199 Bytes (0.00%)
common: 0 Bytes (0.00%)

sahar-fehri requested a review from a team as a code owner October 4, 2023 08:49

sahar-fehri self-assigned this Oct 4, 2023

sahar-fehri added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Oct 4, 2023

sahar-fehri commented Oct 4, 2023

View reviewed changes

sahar-fehri force-pushed the fix/MMASSETS-26-fix-currency-display-in-send-modal branch from 6c95976 to 888715c Compare October 4, 2023 09:14

sahar-fehri force-pushed the fix/MMASSETS-26-fix-currency-display-in-send-modal branch from 888715c to fbf94bb Compare October 4, 2023 11:38

fix: display conversion rate

52c4561

sahar-fehri force-pushed the fix/MMASSETS-26-fix-currency-display-in-send-modal branch from fbf94bb to 52c4561 Compare October 9, 2023 12:54

DDDDDanica approved these changes Oct 10, 2023

View reviewed changes

brad-decker approved these changes Oct 13, 2023

View reviewed changes

sahar-fehri merged commit 001c94b into develop Oct 13, 2023
64 checks passed

sahar-fehri deleted the fix/MMASSETS-26-fix-currency-display-in-send-modal branch October 13, 2023 15:10

github-actions bot locked and limited conversation to collaborators Oct 13, 2023

metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 13, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: display conversion rate #21185

fix: display conversion rate #21185

sahar-fehri commented Oct 4, 2023

github-actions bot commented Oct 4, 2023

sahar-fehri Oct 4, 2023

metamaskbot commented Oct 4, 2023

metamaskbot commented Oct 4, 2023

codecov bot commented Oct 4, 2023 •

edited

Loading

metamaskbot commented Oct 9, 2023

fix: display conversion rate #21185

fix: display conversion rate #21185

Conversation

sahar-fehri commented Oct 4, 2023

Description

Manual testing steps

Screenshots/Recordings

Before

After

Related issues

Pre-merge author checklist

Pre-merge reviewer checklist

github-actions bot commented Oct 4, 2023

sahar-fehri Oct 4, 2023

Choose a reason for hiding this comment

metamaskbot commented Oct 4, 2023

metamaskbot commented Oct 4, 2023

codecov bot commented Oct 4, 2023 • edited Loading

Codecov Report

metamaskbot commented Oct 9, 2023

codecov bot commented Oct 4, 2023 •

edited

Loading