Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Remove account snap allows copy/paste of snap name #21445

Closed
plasmacorral opened this issue Oct 18, 2023 · 1 comment · Fixed by #23993
Closed

[Bug]: Remove account snap allows copy/paste of snap name #21445

plasmacorral opened this issue Oct 18, 2023 · 1 comment · Fixed by #23993
Assignees
@montelaidev
Labels
regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.4.0 release-11.4.0 Issue or pull request that will be included in release 11.4.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 Sev3-low Low severity; minimal to no impact upon users snap-keyring-epic team-accounts type-bug type-enhancement ux-enhancement

Comments

@plasmacorral
Copy link
Contributor

plasmacorral commented Oct 18, 2023 •
edited

Describe the bug

The confirmation to remove a snap that has accounts present in the keyring, requires that the user type the snap name to confirm removal. However, the user can just copy and paste the name of the snap being removed. This is inconsistent with the pattern established to enable eth sign, which does not allow pasting into the text box.

Expected behavior

We have an established pattern for when the user is taking a risky action that the user must type a statement to proceed. This can be observed with enabling eth sign under settings>advanced. Note that when enabling eth sign the user is NOT able to copy the text and paste it into the text entry box.

For the sake of consistency we should disable copy/paste on the snap removal confirmation.

Screenshots/Recordings

No response

Steps to reproduce

  1. Have wallet configured and a snap account created
  2. Go to settings>snaps>Snap simple Keyring
  3. Scroll down and tap the CTA to Remove MetaMask Simple Snap Keyring
  4. Tap continue when the accounts list is displayed
  5. Copy and then paste "MetaMask Simple Snap Keyring" into the text box

Error messages or log output

No response

Version

11.4.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response
@plasmacorral plasmacorral added type-bug regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead release-11.4.0 Issue or pull request that will be included in release 11.4.0 team-accounts Sev3-low Low severity; minimal to no impact upon users labels Oct 18, 2023
@metamaskbot metamaskbot added the regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 label Oct 18, 2023
@plasmacorral plasmacorral added type-enhancement ux-enhancement and removed regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 labels Oct 18, 2023
@metamaskbot metamaskbot added the regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 label Oct 19, 2023
@plasmacorral plasmacorral removed the regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 label Oct 19, 2023
@metamaskbot metamaskbot added the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Oct 20, 2023
@plasmacorral plasmacorral removed the INVALID-ISSUE-TEMPLATE Issue's body doesn't match any issue template. label Oct 20, 2023
@metamaskbot metamaskbot added the regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 label Oct 20, 2023
@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity in the last 90 days. It will be closed in 45 days if there is no further activity. The MetaMask team intends on reviewing this issue before close, and removing the stale label if it is still a bug. We welcome new comments on this issue. We do not intend on closing issues if they report bugs that are still reproducible. Thank you for your contributions.

@github-actions github-actions bot added the stale issues and PRs marked as stale label Jan 24, 2024
@plasmacorral plasmacorral removed the stale issues and PRs marked as stale label Jan 25, 2024
@montelaidev montelaidev self-assigned this Apr 12, 2024
@montelaidev montelaidev mentioned this issue Apr 12, 2024
Merged
7 tasks
montelaidev added a commit that referenced this issue Apr 17, 2024
@montelaidev @danroc
feat: prevent pasting of Snap name during Snap removal (#23993)
f0494a1 
## **Description**

The confirmation to remove a snap that has accounts present in the
keyring, requires that the user type the snap name to confirm removal.
However, the user can just copy and paste the name of the snap being
removed. This PR disables the ability to paste the name.

## **Related issues**

Fixes:
[21445](#21445)

## **Manual testing steps**

1. Create a new snap account
2. Go to settings and click on snap
3. Click on the snap and then remove snap
4. Click continue on the modal
5. Try to copy and paste the snap name in the input.
6. See that the input remains empty.

## **Screenshots/Recordings**

### **Before**


### **After**

## **Pre-merge author checklist**

- [x] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I’ve included tests if applicable
- [x] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
@metamaskbot metamaskbot added the release-11.16.0 Issue or pull request that will be included in release 11.16.0 label Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@montelaidev montelaidev

Labels
regression-prod-11.4.0 Regression bug that was found in production in release 11.4.0 regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead regression-RC-11.4.0 release-11.4.0 Issue or pull request that will be included in release 11.4.0 release-11.16.0 Issue or pull request that will be included in release 11.16.0 Sev3-low Low severity; minimal to no impact upon users snap-keyring-epic team-accounts type-bug type-enhancement ux-enhancement
Projects
Bugs by severity
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: prevent pasting of Snap name during Snap removal MetaMask/metamask-extension
3 participants
@plasmacorral @metamaskbot @montelaidev