-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: prevent pasting of Snap name during Snap removal #23993
feat: prevent pasting of Snap name during Snap removal #23993
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
ui/components/app/snaps/keyring-snap-removal-warning/keyring-snap-removal-warning.tsx
Outdated
Show resolved
Hide resolved
Builds ready [14c3765]
Page Load Metrics (1445 ± 672 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23993 +/- ##
========================================
Coverage 67.52% 67.52%
========================================
Files 1244 1244
Lines 48807 48807
Branches 12747 12747
========================================
Hits 32955 32955
Misses 15852 15852 ☔ View full report in Codecov by Sentry. |
ui/components/app/snaps/keyring-snap-removal-warning/keyring-snap-removal-warning.test.tsx
Outdated
Show resolved
Hide resolved
…nap-removal-warning.test.tsx Co-authored-by: Daniel Rocha <daniel.rocha@consensys.net>
Builds ready [e6def94]
Page Load Metrics (1364 ± 683 ms)
Bundle size diffs
|
Chrome Version 124.0.6367.93 manual testing steps worked as expected, and the user cannot copy and paste the snap name via the keyboard shortcut or edit menu ✅ chrome-pr-23993-test.movFirefox Version 125.0.3 manual testing steps worked as expected, and the user cannot copy and paste the snap name via the keyboard shortcut or edit menu ✅ firefox-pr-23993-test.mov |
Description
The confirmation to remove a snap that has accounts present in the keyring, requires that the user type the snap name to confirm removal. However, the user can just copy and paste the name of the snap being removed. This PR disables the ability to paste the name.
Related issues
Fixes: 21445
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist