[e2e] Signature redesign - Create tests to check info per signature type #23977
Assignees
Labels
INVALID-ISSUE-TEMPLATE
Issue's body doesn't match any issue template.
release-12.0.0
team-confirmations
Push issues to confirmations team
team-confirmations-secure-ux
DEPRECATED: please use "team-confirmations" label instead
Comments
digiwand
added
the
team-confirmations-secure-ux
metamaskbot
added
the
INVALID-ISSUE-TEMPLATE
7 tasks
|
Hey team! Please add your planning poker estimate with Zenhub @digiwand @jpuri @pedronfigueiredo |
7 tasks
digiwand
added a commit
that referenced
this issue
Jun 3, 2024
…24352) <!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. --> ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> [](https://codespaces.new/MetaMask/metamask-extension/pull/24352?quickstart=1) ## **Related issues** Fixes: #23977 Blocked By: #24712 ## **Manual testing steps** 1. set `ENABLE_CONFIRMATION_REDESIGN=true` in .metamaskrc 2. enable Experimental > "Improved signature requests" in settings 3. test signatures in [test-dapp](https://metamask.github.io/test-dapp/) ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Coding Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. --------- Co-authored-by: Priya Narayanaswamy <priya.narayanaswamy@consensys.net>
](https://codespaces.new/MetaMask/metamask-extension/pull/24352?quickstart=1){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
ref: #23552 (comment)
Blocked By: #24712
Create e2e tests:
Request fromdisplays the url with HTTP warning if using HTTP instead of HTTPSInteracting withdisplays the verifying contract addressThe text was updated successfully, but these errors were encountered: