Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Internal Bug]: CircleCI test-e2e-chrome-confirmation-redesign build "Found no drivers" error #24712

Closed
digiwand opened this issue May 22, 2024 · 3 comments
Assignees
Labels
regression-prod-11.16.0 Regression bug that was found in production in release 11.16.0 team-confirmations Push issues to confirmations team

Comments

@digiwand
Copy link
Contributor

digiwand commented May 22, 2024

Describe the bug

Warning: vkCreateInstance: Found no drivers!
Warning: vkCreateInstance failed with VK_ERROR_INCOMPATIBLE_DRIVER
    at CheckVkSuccessImpl (../../third_party/dawn/src/dawn/native/vulkan/VulkanError.cpp:101)

Expected behavior

No response

Screenshots/Recordings

No response

Steps to reproduce

  1. Run CircleCI test-e2e-chrome-confirmation-redesign build
  2. Observe error

Error messages or log output

CleanShot 2024-05-15 at 16 13 07@2x
CleanShot 2024-05-15 at 16 59 00@2x

Version

11.16.0

Build type

None

Browser

Chrome

Operating system

MacOS

Hardware wallet

No response

Additional context

No response

Severity

No response

@digiwand digiwand changed the title [Bug]: CircleCI test-e2e-chrome-confirmation-redesign build "Found no drivers" error [Internal Bug]: CircleCI test-e2e-chrome-confirmation-redesign build "Found no drivers" error May 22, 2024
@metamaskbot metamaskbot added the regression-prod-11.16.0 Regression bug that was found in production in release 11.16.0 label May 22, 2024
@digiwand digiwand added the team-confirmations Push issues to confirmations team label May 22, 2024
@gauthierpetetin
Copy link
Contributor

Hi @digiwand , is this a bug of was it on purpose that you removed the type-bug label?

@digiwand
Copy link
Contributor Author

Hi @gauthierpetetin, I removed the label since it's an internal bug that I think is not yet affecting the related CircleCI build, if I'm not mistaken

@gauthierpetetin
Copy link
Contributor

Ok thanks for the update!

digiwand added a commit that referenced this issue May 24, 2024
<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

created script to build script with ENABLE_CONFIRMATION_REDESIGN flag
and added to test-e2e-chrome-confirmation-redesign command

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24684?quickstart=1)

## **Related issues**
Fixes: #24712
Fixes: #23975
Continues and related to:
#24240

## **Manual testing steps**

check ci/circleci: test-e2e-chrome-confirmation-redesign job

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Priya Narayanaswamy <priya.narayanaswamy@consensys.net>
digiwand added a commit that referenced this issue Jun 3, 2024
…24352)

<!--
Please submit this PR as a draft initially.
Do not mark it as "Ready for review" until the template has been
completely filled out, and PR status checks have passed at least once.
-->

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

[![Open in GitHub
Codespaces](https://github.com/codespaces/badge.svg)](https://codespaces.new/MetaMask/metamask-extension/pull/24352?quickstart=1)

## **Related issues**

Fixes: #23977
Blocked By: #24712

## **Manual testing steps**


1. set `ENABLE_CONFIRMATION_REDESIGN=true` in .metamaskrc
2. enable Experimental > "Improved signature requests" in settings
3. test signatures in [test-dapp](https://metamask.github.io/test-dapp/)

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

- [ ] I’ve followed [MetaMask Coding
Standards](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/CODING_GUIDELINES.md).
- [ ] I've completed the PR template to the best of my ability
- [ ] I’ve included tests if applicable
- [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [ ] I’ve applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-extension/blob/develop/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

---------

Co-authored-by: Priya Narayanaswamy <priya.narayanaswamy@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression-prod-11.16.0 Regression bug that was found in production in release 11.16.0 team-confirmations Push issues to confirmations team
Projects
Archived in project
Status: Fixed
Development

No branches or pull requests

5 participants