Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve handling of last selected provider #10093

Merged
merged 1 commit into from Jan 6, 2021

Conversation

brad-decker
Copy link
Contributor

In #10084 I addressed an issue where the previous provider was not being set when switching to a custom RPC. In this PR, I move the logic for keeping track of the previously connected network to the network controller. Removing the need to keep track of this in appState, and exposing a method to simply rollback to the previous provider.

@metamaskbot
Copy link
Collaborator

Builds ready [2a88627]
Page Load Metrics (507 ± 22 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint31724794
domContentLoaded3255555054622
load3275565074622
domInteractive3255555054622

@brad-decker brad-decker marked this pull request as ready for review December 16, 2020 21:02
@brad-decker brad-decker requested a review from a team as a code owner December 16, 2020 21:02
@brad-decker brad-decker requested review from darkwing and Gudahtt and removed request for darkwing December 16, 2020 21:02
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This looks much simpler than before

@brad-decker brad-decker merged commit b5fc1f9 into develop Jan 6, 2021
@brad-decker brad-decker deleted the improve-last-connected-provider branch January 6, 2021 23:31
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants