Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide reminder to hardware wallet users to have their device ready to confirm transactions #10810

Closed
wants to merge 1 commit into from

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Apr 2, 2021

Explanation:

One of the top reasons users have problems with their hardware wallets is not having the device ready when they confirm a transaction. This PR aims to remind users they must have their hardware wallets ready before confirmation.

Reminder

@darkwing darkwing requested a review from a team as a code owner April 2, 2021 18:55
@darkwing darkwing requested a review from Gudahtt April 2, 2021 18:55
@darkwing darkwing marked this pull request as draft April 2, 2021 18:55
@github-actions
Copy link
Contributor

github-actions bot commented Apr 2, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@darkwing darkwing added the needs-design Needs design support. label Apr 2, 2021
@darkwing darkwing requested a review from rachelcope April 2, 2021 18:55
@rachelcope
Copy link

This is using outdated styles for the notification/alert.

The new style looks like this:
image

This is the issue for the notification/alert system styles. We might need to discuss when the new styles will implemented or if this should just be merged first.

@rachelcope
Copy link

Question on copy... what do you mean by "Ethereum app is open"? Do you mean on the Ledger device itself?

@darkwing
Copy link
Contributor Author

darkwing commented Apr 5, 2021

Question on copy... what do you mean by "Ethereum app is open"? Do you mean on the Ledger device itself?

Yep!

This is using outdated styles for the notification/alert.

As far as I'm aware, this is the generic notification style. @brad-decker do we have a different component I should be using?

@darkwing
Copy link
Contributor Author

darkwing commented Sep 9, 2021

Ryan has a better version of this, closing.

@darkwing darkwing closed this Sep 9, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Sep 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
needs-design Needs design support.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants