Continue jestifying tests #11026
Closed
Continue jestifying tests #11026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
previously approved these changes
May 20, 2021
| entry3.response === null, | ||
| 'all entries should be in correct order and without responses', | ||
| ); | ||
| // expect( |
| EXPECTED_HISTORIES.case1[1], | ||
| 'should have correct history', | ||
| ); | ||
| expect(permHistory).toStrictEqual(EXPECTED_HISTORIES.case1[1]); |
There was a problem hiding this comment.
Are we going to miss comments like 'should have correct history'?
Builds ready [f909ef2]
Page Load Metrics (664 ± 48 ms)
|
SirJosh1987
approved these changes
Jun 3, 2021
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
dan437
approved these changes
Jun 28, 2021
| @@ -1,5 +1,5 @@ | |||
| /* eslint-disable jest/no-conditional-expect */ | |||
There was a problem hiding this comment.
Could we set this ESLint rule globally instead of having it in individual files?
SirJosh1987
approved these changes
Jun 30, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ommited
due to a issues with the ganache server instance, poorly written, and general compatibility with jest. Most likely will have to rethink/rewrite these from the ground up.
Pinned jest-enviornment-jsdom to 25 for Uint8Array Buffer issue in jest <= 26, jestjs/jest#7780