Show Sentry CLI output when uploading artifacts #11100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds ready [0f84685]
Page Load Metrics (645 ± 57 ms)
|
|
This depends upon #11085 |
Gudahtt
force-pushed
the
use-run-command-for-sentry-cli
branch
from
0f84685
to
7a86e1d
Compare
Builds ready [7a86e1d]
Page Load Metrics (660 ± 49 ms)
|
Gudahtt
force-pushed
the
use-run-command-for-sentry-cli
branch
from
7a86e1d
to
9c3df97
Compare
Builds ready [9c3df97]
Page Load Metrics (603 ± 41 ms)
|
Base automatically changed from
extract-sentry-account-details-to-environment-variables
to
develop
May 18, 2021 16:26
Gudahtt
force-pushed
the
use-run-command-for-sentry-cli
branch
from
9c3df97
to
4b81ed7
Compare
Builds ready [4b81ed7]
Page Load Metrics (571 ± 40 ms)
|
darkwing
reviewed
May 19, 2021
The function we were using to run shell commands during the `sentry:publish` script were swallowing the CLI output. We also weren't correctly detecting the process exit in some cases. The `run-command` module originally written for `auto-changelog` (introduced in #10782 and replaced in #10993) has been resurrected for running commands where we don't care about the output, or where we want to use the output for something. A second function (`runInShell`) has been added for running commands with the same STDOUT and STDERR streams, so that the output is sent directly to the CLI. This ensures that the console output from the shell script we run gets correctly output to the CLI.
Gudahtt
force-pushed
the
use-run-command-for-sentry-cli
branch
from
4b81ed7
to
46d01ca
Compare
Builds ready [46d01ca]
Page Load Metrics (645 ± 39 ms)
|
|
Awesome, this worked perfectly as described. Well done @Gudahtt ! |
darkwing
approved these changes
May 19, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function we were using to run shell commands during the
sentry:publishscript were swallowing the CLI output. We also weren't correctly detecting the process exit in some cases.The
run-commandmodule originally written forauto-changelog(introduced in #10782 and replaced in #10993) has been resurrected for running commands where we don't care about the output, or where we want to use the output for something. A second function (runInShell) has been added for running commands with the same STDOUT and STDERR streams, so that the output is sent directly to the CLI. This ensures that the console output from the shell script we run gets correctly output to the CLI.Manual testing steps for release artifact publishing:
yarn sentry:publishwith the environment variableSENTRY_AUTH_TOKENset to the token from that integration, and withSENTRY_ORGset to your account name andSENTRY_PROJECTset to the project name you created.You can also try testing with either of the three required environment variables missing, to see that the error cases behave correctly.