Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build - log the bundle completion #11555

Merged
merged 1 commit into from Jul 20, 2021
Merged

build - log the bundle completion #11555

merged 1 commit into from Jul 20, 2021

Conversation

kumavis
Copy link
Member

@kumavis kumavis commented Jul 17, 2021

now logs the name of the bundle at start and end
ideally this would happen via each task ending,
but currently tasks dont end when they are watching the filesystem

@kumavis kumavis requested a review from a team as a code owner July 17, 2021 17:36
@kumavis kumavis requested a review from PeterYinusa July 17, 2021 17:36
@metamaskbot
Copy link
Collaborator

Builds ready [56fa972]
Page Load Metrics (623 ± 26 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint53866484
domContentLoaded5257646225325
load5267666235326
domInteractive5257646225325

@darkwing
Copy link
Contributor

Works for me! Would be cool in the future to use Chalk (https://davidwalsh.name/chalk) to use green and yellow for end and start, but obviously not important right now.

@ryanml ryanml merged commit 284c038 into develop Jul 20, 2021
@ryanml ryanml deleted the build-bundle-label branch July 20, 2021 16:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants