Dont default gas limit in gas popover when non is available on transaction params #11872
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the default value for gas limit in our gas editing popover. This case will only occur if no gas limit was suggested by a dapp, and calls to
eth_estimateGas
have failed not due to a simulation error, but a network failure. This would happen if the user is disconnected from the internet, or there is a failure connecting to the provider. In such a case, defaulting to 0 is safe because it requires the user to be intentional about the gas limit.