Remove type=number from the max priority fee field. #12041
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Akintayo A. Olusegun <akintayo.segun@gmail.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [3c63916]
Page Load Metrics (485 ± 47 ms)
|
Gudahtt
reviewed
Sep 8, 2021
| @@ -68,7 +68,6 @@ export default function AdvancedGasControls({ | |||
| }} | |||
| value={maxPriorityFee} | |||
| detailText={maxPriorityFeeFiat} | |||
| numeric | |||
There was a problem hiding this comment.
This flag does more than set the type of the input element to number. It also ensures the onChange value is a number, and might do other things as well.
If we're considering removing type=number, we should probably remove it from the NumericInput component.
There was a problem hiding this comment.
I agree with @Gudahtt here -- I don't believe we want to remove this.
|
@segun Should we close this or do you plan on updating? |
mcmire
added
the
needs-decision
|
Closing this as I think we have a different type of fix |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Akintayo A. Olusegun akintayo.segun@gmail.com
Fixes: #11876
Explanation:
On the gas override dialog (and really all of the dialogs), type=number is very difficult to interact with as a user.
One major glaring issue is that you can't delete the 0 by hitting the delete key. This results in people typing in 010.
Manual testing steps: