Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

limit x server check to CI #12099

Merged
merged 1 commit into from Sep 14, 2021
Merged

limit x server check to CI #12099

merged 1 commit into from Sep 14, 2021

Conversation

PeterYinusa
Copy link
Contributor

Related: #12043

Explanation: Allows you to run metamask-ui.spec.js e2e tests locally using Chrome

@PeterYinusa PeterYinusa requested a review from a team as a code owner September 14, 2021 11:29
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [2b57a13]
Page Load Metrics (369 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint7051922613967
domContentLoaded2605203546833
load2795293696933
domInteractive2605203546833

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
Copy link
Contributor

mcmire commented Sep 14, 2021

Blurgh, I thought I did this already 😆 Thank you!

@PeterYinusa PeterYinusa merged commit 34f2d3e into develop Sep 14, 2021
@PeterYinusa PeterYinusa deleted the limit-xserver-check-to-ci branch September 14, 2021 16:03
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants