Update warning message when Ledger app has contract data/blind signin… #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g setting disabled
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
I have read the CLA Document and I hereby sign the CLA |
danjm
approved these changes
Oct 7, 2021
darkwing
approved these changes
Oct 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…g setting disabled
Explanation:
Since Ethereum app v1.9.6, the setting "Enable contract data" has been updated to "Enable Blind Signing".
(see LedgerHQ/app-ethereum@fa355a5#diff-505735aabef6c5a02c985965bbd815d8a79571140dec87d7757c633e7dace64aR59 )
This PR updates Metamask error message so that it handles both cases, new and legacy.
Manual testing steps: