Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unit test package scripts #12278

Merged
merged 1 commit into from Oct 6, 2021
Merged

Fix unit test package scripts #12278

merged 1 commit into from Oct 6, 2021

Conversation

rekmarks
Copy link
Member

@rekmarks rekmarks commented Oct 4, 2021

This PR fixes our local unit test package scripts. When the state migration unit tests were migrated to Jest in #12106, it left the test:unit script in a broken state, because it didn't tell mocha to ignore the state migration tests.

Arguably, that script was already broken, since the most reasonably expectation from its name is that it runs all unit tests. The PR makes it so that it does just that, by means of concurrently.

Unfortunately, concurrently only outputs errors from child processes once (at the time when they exit, open-cli-tools/concurrently#134). This means that we have to search/navigate the output for this combined script to identify the failure. That said, it's better than the status quo.

@rekmarks rekmarks requested a review from a team as a code owner October 4, 2021 20:34
@rekmarks rekmarks requested a review from darkwing October 4, 2021 20:34
@metamaskbot
Copy link
Collaborator

Builds ready [ae0ea77]
Page Load Metrics (297 ± 28 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint614202478943
domContentLoaded2334102815828
load2504402975828
domInteractive2334102815828

Copy link
Contributor

@jpuri jpuri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change 👍

@rekmarks rekmarks merged commit 822ce5b into develop Oct 6, 2021
@rekmarks rekmarks deleted the fix-unit-test-scripts branch October 6, 2021 14:35
@github-actions github-actions bot locked and limited conversation to collaborators Oct 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants