Show account name & full address in send view - issue #12346 #12415
Conversation
|
I have read the CLA Document and I hereby sign the CLA |
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
FROM the bug in TO send_accountdisplay_pr.mov |
igorms-cons
force-pushed
the
fix/ux_papercuts_accountname_sendflow
branch
from
d768c26
to
a0b1638
Compare
|
Verified by QA |
igorms-cons
force-pushed
the
fix/ux_papercuts_accountname_sendflow
branch
from
ce4ff14
to
bb02f91
Compare
igorms-cons
force-pushed
the
fix/ux_papercuts_accountname_sendflow
branch
2 times, most recently
from
6c04d61
to
a2eb9cf
Compare
|
Retested - verified by QA |
igorms-cons
force-pushed
the
fix/ux_papercuts_accountname_sendflow
branch
from
a2eb9cf
to
5b3367f
Compare
| </div> | ||
| {selectedName && ( | ||
| {selectedName !== selectedAddress && ( |
There was a problem hiding this comment.
could these ever be equal?
There was a problem hiding this comment.
HI @adonesky1 ,
for now yes because getAddressBookEntryOrAccountName function is returning the address if there is no name (in case of new address added) return entry && entry.name !== '' ? entry.name : address;
I can leave it empty string if no name and change back to what it was written in esn-input.js
{selectedName && (...)
There was a problem hiding this comment.
let me know :) @adonesky1
There was a problem hiding this comment.
this makes sense, I think approach in this PR is fine
Fixes: # Add user own accounts in the search
Explanation: Paste address was only searched in user address book.
Manual testing steps:
See issue #12346