Changed ETH decimal values to have 8 places for sending #12437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
VSaric
force-pushed
the
fix/eth-decimal-values
branch
from
b7848ee
to
851be99
Compare
|
Verified by QA |
VSaric
force-pushed
the
fix/eth-decimal-values
branch
from
851be99
to
d0c9442
Compare
david0xd
approved these changes
Oct 27, 2021
NiranjanaBinoy
approved these changes
Nov 5, 2021
ryanml
approved these changes
Nov 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11420
Explanation for screenshot number one: When user want to send ETH to an address, user can insert 8 decimal places and Metamask round up values after 8 decimal places.
Screenshot number one:
Explanation for screenshot number two: After typing the value 1.23456789, we would expect to see the same value in the input field as well as on the Confirmation screen when we click Next.
Screenshot number two:
