Unlimited/proposed approved limit fix #12511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
jj-crypto
previously approved these changes
Oct 28, 2021
|
Verified by QA |
filipsekulic
force-pushed
the
fix/approve-confirmation
branch
from
22fda63
to
0e9ed1b
Compare
filipsekulic
force-pushed
the
fix/approve-confirmation
branch
from
0e9ed1b
to
1923297
Compare
david0xd
approved these changes
Nov 1, 2021
danjm
approved these changes
Nov 1, 2021
|
Looks good! Approved |
darkwing
approved these changes
Nov 1, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #11125
Fix unlimited/proposed approved limit fix for cases:
Proposed Approval Limit is when:
amount < max(uint256)
Unlimited is when:
amount == max(uint256)