Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show correct base asset in Signature Request view #12696

Merged
merged 1 commit into from Nov 15, 2021
Merged

Show correct base asset in Signature Request view #12696

merged 1 commit into from Nov 15, 2021

Conversation

ryanml
Copy link
Contributor

@ryanml ryanml commented Nov 13, 2021

Fixes: #12689

ETH (Rinkeby)
Screen Shot 2021-11-13 at 12 44 54 PM

BSC
Screen Shot 2021-11-13 at 12 45 42 PM

Polygon
Screen Shot 2021-11-13 at 12 47 29 PM

@ryanml ryanml requested a review from danjm November 13, 2021 19:57
@ryanml ryanml self-assigned this Nov 13, 2021
@ryanml ryanml requested a review from a team as a code owner November 13, 2021 19:57
@metamaskbot
Copy link
Collaborator

Builds ready [d85786e]
Page Load Metrics (800 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint292805482210101
domContentLoaded73111117998541
load73111138008541
domInteractive73111117998541

@ryanml ryanml merged commit a203337 into develop Nov 15, 2021
@ryanml ryanml deleted the fix-12689 branch November 15, 2021 17:19
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@danjm danjm danjm approved these changes

Assignees

@ryanml ryanml

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

when signing on a custom network with a base asset other than ETH, the base asset is shown as ETH.
4 participants
@ryanml @metamaskbot @darkwing @danjm