Added SiteOrigin and PermissionList components #12832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [7bc0903]Page Load Metrics (768 ± 12 ms)
highlights:storybook
|
ritave
changed the title
Builds ready [e98117d]Page Load Metrics (849 ± 31 ms)
highlights:storybook
|
There was a problem hiding this comment.
Looks good!! Some questions and small suggestions. UI components could use some stories.
ui/components/app/permissions-connect-permission-list/permissions-connect-list.stories.js
import React from 'react';
import PermissionsConnectList from '.';
export default {
title: 'Components/App/PermissionsConnectList',
id: __filename,
component: PermissionsConnectList,
argTypes: {
permissions: {
control: 'object',
},
},
};
export const DefaultStory = (args) => <PermissionsConnectList {...args} />;
DefaultStory.storyName = 'Default';
DefaultStory.args = {
permissions: {
eth_accounts: {
leftIcon: 'fas fa-eye',
label: 'eth_accounts',
rightIcon: null,
},
},
};
ui/components/ui/site-origin/site-origin.stories.js
import React from 'react';
import SiteOrigin from '.';
export default {
title: 'Components/UI/SiteOrigin',
id: __filename,
component: SiteOrigin,
argTypes: {
siteOrigin: {
control: 'text',
},
iconSrc: {
control: 'text',
},
iconName: {
control: 'text',
},
},
};
export const DefaultStory = (args) => <SiteOrigin {...args} />;
DefaultStory.storyName = 'Default';
DefaultStory.args = {
siteOrigin: 'https://metamask.io/',
iconName: 'MetaMask',
iconSrc: './metamark.svg',
};
ui/components/app/permissions-connect-permission-list/permissions-connect-permission-list.js
Outdated
Show resolved
Hide resolved
ui/components/app/permissions-connect-permission-list/permissions-connect-permission-list.js
Outdated
Show resolved
Hide resolved
Gudahtt
reviewed
Nov 26, 2021
ui/components/app/permissions-connect-permission-list/permissions-connect-permission-list.js
Outdated
Show resolved
Hide resolved
Gudahtt
reviewed
Nov 26, 2021
ritave
force-pushed
the
ritave/snaps-install
branch
2 times, most recently
from
a9c4670
to
86447cc
Compare
darkwing
reviewed
Nov 30, 2021
| <div className="permissions-connect-permission-list"> | ||
| {Object.keys(permissions) | ||
| .map((permission) => PERMISSION_TYPES[permission]) | ||
| .map((permission) => ( |
There was a problem hiding this comment.
I'd prefer that we didn't double map; it seems reasonable to use PERMISSION_TYPES[permission].label, etc.
|
I had two concerns regarding the
|
|
@hmalik88 Fixed the max-width |
Builds ready [e0ed8a4]Page Load Metrics (814 ± 19 ms)
highlights:storybook
|
hmalik88
reviewed
Dec 1, 2021
ui/components/ui/chip/chip.js
Outdated
| @@ -35,6 +36,7 @@ export default function Chip({ | |||
| 'chip--with-right-icon': Boolean(rightIcon), | |||
| [`chip--border-color-${borderColor}`]: true, | |||
| [`chip--background-color-${backgroundColor}`]: true, | |||
| 'chip--max-conent': maxContent, | |||
There was a problem hiding this comment.
I think you have a typo here, should be: 'chip--max-content'
hmalik88
reviewed
Dec 1, 2021
| @@ -174,7 +174,6 @@ export default class PermissionConnect extends Component { | |||
| className="permissions-connect__back" | |||
| onClick={() => this.goBack()} | |||
| > | |||
| <i className="fas fa-chevron-left" /> | |||
There was a problem hiding this comment.
I believe @holantonela updated the design to keep this
ritave
force-pushed
the
ritave/snaps-install
branch
from
e0ed8a4
to
957db9b
Compare
Builds ready [99a7c0f]Page Load Metrics (973 ± 29 ms)
highlights:storybook
|
darkwing
approved these changes
Dec 2, 2021
georgewrmarshall
approved these changes
Dec 2, 2021
| @@ -174,7 +174,7 @@ export default class PermissionConnect extends Component { | |||
| className="permissions-connect__back" | |||
| onClick={() => this.goBack()} | |||
| > | |||
| <i className="fas fa-chevron-left" /> | |||
| <i className="fas fa-chevron-left"></i> | |||
There was a problem hiding this comment.
nit: Could use self-closing tag here
Suggested change
| <i className="fas fa-chevron-left"></i> | |
| <i className="fas fa-chevron-left" /> |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made to the flow: