Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump eth-json-rpc-middlware from 8.0.0 to 8.0.1 #13005

Merged
merged 1 commit into from
Dec 7, 2021

Conversation

tmashuang
Copy link
Contributor

@tmashuang tmashuang commented Dec 7, 2021

Fixes: #12995

Explanation: Adds the query string to the url. MetaMask/eth-json-rpc-middleware@v8.0.0...v8.0.1

Manual testing steps:

@tmashuang tmashuang requested a review from a team as a code owner December 7, 2021 18:27
@tmashuang tmashuang requested a review from danjm December 7, 2021 18:27
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2021

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Gudahtt Gudahtt mentioned this pull request Dec 7, 2021
@metamaskbot
Copy link
Collaborator

Builds ready [bfda8b2]
Page Load Metrics (993 ± 31 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint611131446465223
domContentLoaded91511369926632
load92311369936531
domInteractive91511369926632

@tmashuang tmashuang merged commit 4d9a2a8 into develop Dec 7, 2021
@tmashuang tmashuang deleted the update-eth-json-rpc-middleware branch December 7, 2021 19:13
@github-actions github-actions bot locked and limited conversation to collaborators Dec 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metamask 10.7 does not work with URL that contains query parameters.
4 participants