Remove new address alert #14811

ryanml · 2022-06-01T05:30:59Z

Fixes: #14783

Explanation

See background in issue

Manual Testing Steps

Go through the send flow attempting to send to an account that is not in your address book
Ensure the New address detected notification does not show (See videos in Issue)

georgewrmarshall

Tested sending Rinkeby eth to new address. LGTM!

metamaskbot · 2022-06-02T05:32:33Z

Builds ready [afff7c7]

builds: chrome, firefox, opera
builds (beta): chrome, firefox, opera
builds (flask): chrome, firefox, opera
build viz: Build System
code coverage: Report
storybook: Storybook
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5, 6, 7
- common: 0, 1, 2, 3, 4, 5, 6, 7, 8
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- phishing-detect: phishing-detect
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1833 ± 85 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	77	1630	187	331	159
		domContentLoaded	1636	2181	1815	184	88
		load	1643	2182	1833	177	85
		domInteractive	1636	2181	1815	184	88

highlights:

storybook

Nunnaphat1234

Hi

segun

I tested this and I can confirm the Add contact dialog is no longer shown

darkwing · 2022-06-08T21:14:15Z

Tested and works well but I think we should add some padding here:

github-actions · 2022-06-14T14:07:56Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

darkwing · 2022-06-14T14:08:19Z

Took the opportunity to update the padding:

Also removed an unused prop

georgewrmarshall · 2022-06-15T21:24:42Z

Further riffing on this. To remove assumed padding of child and to clean up the jsx a bit

Before

After

bschorchit · 2022-08-23T00:35:30Z

Noticed this PR got the two needed approvals, but ended up not being merged due to conflicts. Should we resolve them? cc: @ryanml

pedronfigueiredo · 2022-11-28T13:27:38Z

I ran into an interesting issue on edit-gas-fee.spec.js, coming from the NumericInput component inside FormField, inside base-fee-input.

Decimal separators , or . cannot be written at the end of the input field. Doing so causes the input field to clear.

Writing the , separator in the middle of the number of characters works.

Since this is unrelated to this branch's change (develop is similarly broken), I modified said broken e2e test case so that it wouldn't fail. The bug is captured on a separate issue (#16703), as part of which it should be fixed and tested.

metamaskbot · 2022-12-07T12:19:47Z

Builds ready [e0da180]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2013 ± 189 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	91	181	115	26	12
		domContentLoaded	1511	2983	2004	392	188
		load	1511	2983	2013	393	189
		domInteractive	1511	2983	2004	392	188

Bundle size diffs

background: 0 bytes
ui: -1880 bytes
common: 0 bytes

highlights:

storybook

metamaskbot · 2022-12-07T13:35:45Z

Builds ready [8601aac]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2089 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	189	129	22	11
		domContentLoaded	1603	2537	2084	215	103
		load	1619	2537	2089	207	99
		domInteractive	1603	2537	2084	215	103

Bundle size diffs

background: 0 bytes
ui: -1984 bytes
common: 0 bytes

highlights:

storybook

metamaskbot · 2022-12-07T14:18:27Z

Builds ready [4004d61]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2102 ± 119 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	92	151	111	16	8
		domContentLoaded	1546	2504	2067	242	116
		load	1546	2529	2102	249	119
		domInteractive	1546	2504	2067	242	116

Bundle size diffs

background: 0 bytes
ui: -1984 bytes
common: 0 bytes

highlights:

storybook

metamaskbot · 2022-12-07T16:28:57Z

Builds ready [152ed99]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2196 ± 99 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	241	140	32	15
		domContentLoaded	1716	2499	2180	211	101
		load	1716	2499	2196	206	99
		domInteractive	1716	2499	2180	211	101

Bundle size diffs

background: 0 bytes
ui: -1984 bytes
common: 0 bytes

highlights:

storybook

jpuri

Nice cleanup 👍

metamaskbot · 2022-12-08T09:53:26Z

Builds ready [c0e34a0]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2148 ± 106 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	104	272	142	38	18
		domContentLoaded	1724	2474	2118	228	109
		load	1724	2474	2148	220	106
		domInteractive	1724	2474	2118	228	109

Bundle size diffs

background: 0 bytes
ui: -1984 bytes
common: 0 bytes

highlights:

storybook

metamaskbot · 2022-12-08T13:28:20Z

Builds ready [5583dda]

builds: chrome, firefox
builds (beta): chrome, firefox
builds (flask): chrome, firefox
build viz: Build System
mv3: Background Module Init Stats
mv3: UI Init Stats
mv3: Module Load Stats
mv3: Bundle Size Stats
mv2: E2e Actions Stats
code coverage: Report
storybook: Storybook
typescript migration: Dashboard
all artifacts
bundle viz:
- background: 0, 1, 2, 3, 4, 5
- common: 0, 1, 2, 3, 4, 5, 6, 7
- content-script: 0
- contentscript: contentscript
- disable-console: disable-console
- inpage: inpage
- policy-load: policy-load
- sentry-install: sentry-install
- ui: 0, 1, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (2241 ± 130 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	101	173	128	22	11
		domContentLoaded	1672	2852	2211	255	123
		load	1672	2961	2241	271	130
		domInteractive	1672	2852	2211	255	122

Bundle size diffs

background: 0 bytes
ui: -1984 bytes
common: 0 bytes

highlights:

storybook

ryanml requested a review from georgewrmarshall June 1, 2022 05:30

ryanml requested a review from a team as a code owner June 1, 2022 05:31

ryanml self-assigned this Jun 1, 2022

ryanml force-pushed the fix-14783 branch 2 times, most recently from 768dc3e to 8cbf002 Compare June 1, 2022 06:44

georgewrmarshall previously approved these changes Jun 1, 2022

View reviewed changes

ryanml dismissed georgewrmarshall’s stale review via 7ce7d99 June 2, 2022 02:27

ryanml force-pushed the fix-14783 branch 2 times, most recently from 7ce7d99 to afff7c7 Compare June 2, 2022 04:44

ryanml requested a review from georgewrmarshall June 2, 2022 05:29

Nunnaphat1234 reviewed Jun 2, 2022

View reviewed changes

MetaMask deleted a comment from Nunnaphat1234 Jun 3, 2022

segun previously approved these changes Jun 8, 2022

View reviewed changes

darkwing dismissed stale reviews from ghost and segun via e8d4e3f June 14, 2022 14:07

ryanml requested a review from segun June 15, 2022 03:19

ryanml force-pushed the fix-14783 branch from e8d4e3f to 3c845af Compare June 15, 2022 03:19

georgewrmarshall force-pushed the fix-14783 branch from 3c845af to 266ec7b Compare June 15, 2022 21:19

ryanml dismissed a stale review via 2edf874 July 12, 2022 14:22

ryanml force-pushed the fix-14783 branch from b9a66db to 2edf874 Compare July 12, 2022 14:22

brad-decker previously approved these changes Jul 12, 2022

View reviewed changes

darkwing previously approved these changes Jul 12, 2022

View reviewed changes

danjm added the PR - P1 identifies PRs deemed priority for Extension team label Jul 20, 2022

Merge branch 'develop' into fix-14783

ae90612

pedronfigueiredo force-pushed the fix-14783 branch from 29ecaaa to ae90612 Compare November 25, 2022 13:57

pedronfigueiredo added 2 commits November 25, 2022 14:26

remove unused copy

7ed7409

fix broken e2e test

bca7382

pedronfigueiredo added 3 commits November 28, 2022 15:50

rework layout nesting

18f30eb

satisfy lint

2984e2d

change layout to fix firefox tests

7d65dc6

pedronfigueiredo force-pushed the fix-14783 branch from 6713250 to 7d65dc6 Compare November 28, 2022 16:30

change selector specificity on e2e test

e0da180

pedronfigueiredo added 3 commits December 7, 2022 12:33

Merge branch 'develop' into fix-14783

f5a81a4

revert test change after fix has been merged from develop

c34cc6a

fix linting

8601aac

Merge branch 'develop' into fix-14783

4004d61

Merge branch 'develop' into fix-14783

152ed99

jpuri approved these changes Dec 7, 2022

View reviewed changes

pedronfigueiredo assigned pedronfigueiredo and unassigned ryanml Dec 8, 2022

Merge branch 'develop' into fix-14783

c0e34a0

Merge branch 'develop' into fix-14783

5583dda

brad-decker approved these changes Dec 8, 2022

View reviewed changes

pedronfigueiredo merged commit a759d42 into develop Dec 8, 2022

pedronfigueiredo deleted the fix-14783 branch December 8, 2022 14:20

github-actions bot locked and limited conversation to collaborators Dec 8, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove new address alert #14811

Remove new address alert #14811

ryanml commented Jun 1, 2022

georgewrmarshall left a comment •

edited

metamaskbot commented Jun 2, 2022

Nunnaphat1234 left a comment •

edited

segun left a comment

darkwing commented Jun 8, 2022

github-actions bot commented Jun 14, 2022 •

edited

darkwing commented Jun 14, 2022 •

edited

georgewrmarshall commented Jun 15, 2022 •

edited

bschorchit commented Aug 23, 2022

pedronfigueiredo commented Nov 28, 2022

metamaskbot commented Dec 7, 2022

metamaskbot commented Dec 7, 2022

metamaskbot commented Dec 7, 2022

metamaskbot commented Dec 7, 2022

jpuri left a comment

metamaskbot commented Dec 8, 2022

metamaskbot commented Dec 8, 2022

Remove new address alert #14811

Remove new address alert #14811

Conversation

ryanml commented Jun 1, 2022

Explanation

Manual Testing Steps

georgewrmarshall left a comment • edited

Choose a reason for hiding this comment

metamaskbot commented Jun 2, 2022

highlights:

Nunnaphat1234 left a comment • edited

Choose a reason for hiding this comment

segun left a comment

Choose a reason for hiding this comment

darkwing commented Jun 8, 2022

github-actions bot commented Jun 14, 2022 • edited

darkwing commented Jun 14, 2022 • edited

georgewrmarshall commented Jun 15, 2022 • edited

Before

After

bschorchit commented Aug 23, 2022

pedronfigueiredo commented Nov 28, 2022

metamaskbot commented Dec 7, 2022

highlights:

metamaskbot commented Dec 7, 2022

highlights:

metamaskbot commented Dec 7, 2022

highlights:

metamaskbot commented Dec 7, 2022

highlights:

jpuri left a comment

Choose a reason for hiding this comment

metamaskbot commented Dec 8, 2022

highlights:

metamaskbot commented Dec 8, 2022

highlights:

georgewrmarshall left a comment •

edited

Nunnaphat1234 left a comment •

edited

github-actions bot commented Jun 14, 2022 •

edited

darkwing commented Jun 14, 2022 •

edited

georgewrmarshall commented Jun 15, 2022 •

edited