Prevent confirm screen from showing method name from contract registry for txes created within MetaMask #15472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y for txes created within MetaMask
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
…act, with tx data, from metamask send screen
brad-decker
approved these changes
Aug 4, 2022
|
QA pass |
Builds ready [6fb0efb]
Page Load Metrics (1716 ± 63 ms)
highlights:storybook
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation:
Prior to v10.18.2, if we edited hex data on the send screen and sent to a contract address, we incorrectly identified it as a simple send. On 10.18.2 we correctly represent it as a contract interaction, but by doing so we show the name of the method associated with that 4-byte signature from the registry.
This PR maintains the representation of these transactions as contract interactions, but ensures that if they are created from within MetaMask, we don't show any specific names, to avoid any possibility of showing incorrect or malicious info to the user in these cases.
before:
after:
