Ability to buy tokens with Wyre #15992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
@brad-decker tagging you once again since its part of the same batch of changes you have been reviewing |
brad-decker
approved these changes
Sep 27, 2022
darkwing
approved these changes
Sep 28, 2022
|
Thank you @nikoferro ! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This extends this already merged PRs: #15551 #15924
and adds Wyre as an extra onramp provider for tokens
Current State: Only native currencies can be bought through Wyre using the buy button
After Change: Ability to purchase tokens defined in
BUYABLE_CHAINS_MAPusing WyreMore Information
This depends on a swap-api changed which has already been deployed, this is why it hasn't been included on previous PRs
Screenshots/Screencaps
Before
After
Manual Testing Steps
Import a token
If token is on the Wyre lists it should display a "Buy" button
Once you click on the provider's "Continue to" button, a window on said provider should open, and the token to buy should already be preselected
Pre-Merge Checklist
+ If there are functional changes: