Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Fix some issues with installing snaps that request eth_accounts #16365

Merged
merged 2 commits into from Nov 4, 2022

Conversation

FrederikBolding
Copy link
Member

Explanation

Fixes some issues with installing snaps that request the eth_accounts permission AND other permissions. Reported by a user in Discord.

Manual Testing Steps

  1. Create a snap with the following permissions
  "initialPermissions": {
    "eth_accounts": {
      "requiredMethods": []
    },
    "snap_confirm": {},
    "snap_manageState": {},
    "endowment:network-access": {},
    "snap_getBip44Entropy": [
      {
        "coinType": 60
      }
    ]
  },
  1. Verify that the snap can install successfully

@metamaskbot
Copy link
Collaborator

Builds ready [2cfb234]
Page Load Metrics (2228 ± 127 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint902616235546262
domContentLoaded170826162203257124
load170826762228264127
domInteractive170826162203257124

@FrederikBolding FrederikBolding merged commit 121b680 into develop Nov 4, 2022
@FrederikBolding FrederikBolding deleted the fb/fix-issue-with-eth-accounts-snaps branch November 4, 2022 11:50
@github-actions github-actions bot locked and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants