Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable new networks for Swaps #16396

Merged
merged 6 commits into from Nov 8, 2022
Merged

Enable new networks for Swaps #16396

merged 6 commits into from Nov 8, 2022

Conversation

dan437
Copy link
Contributor

@dan437 dan437 commented Nov 7, 2022

Explanation

This PR enables Arbitrum and Optimism for Swaps. Most of the work for this was done on backend, frontend just needs a few small changes to enable it.

Manual testing steps

  • Start the extension with SWAPS_USE_DEV_APIS=1 yarn start
  • Add Avalanche and Optimism into networks in MM
  • Test out Swaps

@dan437 dan437 requested a review from a team as a code owner November 7, 2022 13:49
@dan437 dan437 requested a review from darkwing November 7, 2022 13:49
@github-actions
Copy link
Contributor

github-actions bot commented Nov 7, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

brad-decker
brad-decker previously approved these changes Nov 7, 2022
@dan437 dan437 marked this pull request as draft November 8, 2022 08:41
Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Didn't test because I don't have Optimism or Arbitrum ETH but code LGTM!

@brad-decker
Copy link
Member

I happen to have both, and tested. FTW ❤️

@dan437 dan437 merged commit 1a9ebab into MetaMask:develop Nov 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2022
@dan437 dan437 deleted the new-networks branch July 24, 2023 11:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants