Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Privacy - Allow users to set a custom RPC from the onboarding process #16767

Merged
merged 6 commits into from
Dec 2, 2022
Merged

Privacy - Allow users to set a custom RPC from the onboarding process #16767

merged 6 commits into from
Dec 2, 2022

Conversation

darkwing
Copy link
Contributor

@darkwing darkwing commented Dec 1, 2022

Explanation

Screenshots/Screencaps

OnboardingNetwork.mp4

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner December 1, 2022 21:02
@darkwing darkwing requested review from georgewrmarshall and removed request for a team December 1, 2022 21:02
@github-actions
Copy link
Contributor

github-actions bot commented Dec 1, 2022

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [03120bb]
Page Load Metrics (3642 ± 280 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1401506750576277
domContentLoaded279549283618600288
load290949283642584280
domInteractive279549283618600288
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 71054 bytes
  • common: 12 bytes

highlights:

storybook

@danjm
Copy link
Contributor

danjm commented Dec 2, 2022

We should remove the <a> tag around the settings word so that there is no broken link
Screenshot from 2022-12-02 15-07-43

@metamaskbot
Copy link
Collaborator

Builds ready [de214e9]
Page Load Metrics (2475 ± 342 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1061383322437210
domContentLoaded168140982464720346
load175340982475713342
domInteractive168140982464720346
Bundle size diffs [🚨 Warning! Bundle size has increased!]
  • background: 0 bytes
  • ui: 72527 bytes
  • common: 12 bytes

highlights:

storybook

danjm
danjm approved these changes Dec 2, 2022
View reviewed changes
Copy link
Contributor

@danjm danjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@darkwing darkwing merged commit 4b4a45f into new-onboarding-privacy Dec 2, 2022
@darkwing darkwing deleted the new-onboarding-privacy-modal branch December 2, 2022 20:50
@github-actions github-actions bot locked and limited conversation to collaborators Dec 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@danjm danjm danjm approved these changes

@pedronfigueiredo pedronfigueiredo pedronfigueiredo approved these changes

@georgewrmarshall georgewrmarshall Awaiting requested review from georgewrmarshall georgewrmarshall is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darkwing @metamaskbot @danjm @pedronfigueiredo