bump @metamask/smart-transactions-controller version
#17120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
adonesky1
force-pushed
the
bump-smart-transaction-controller-version
branch
from
4834318
to
8fbf098
Compare
Builds ready [8fbf098]
Page Load Metrics (1558 ± 263 ms)
Bundle size diffs [🚀 Bundle size reduced!]
|
adonesky1
changed the title
@metamask/smart-transactions-controller version
adonesky1
commented
Jan 12, 2023
| this.networkController.store.subscribe((networkState) => { | ||
| const modifiedNetworkState = { | ||
| ...networkState, | ||
| providerConfig: { |
There was a problem hiding this comment.
the smart-transaction-controller types the networkState using a type from @metamask/network-controller (from @metamask/core-monorepo) that was recently updated to expect property providerConfig in place of provider: https://github.com/MetaMask/core/blob/main/packages/network-controller/CHANGELOG.md?plain=1#L11
danjm
approved these changes
Jan 12, 2023
jpuri
approved these changes
Jan 12, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Bumps
@metamask/smart-transactions-controllerversion tov3.1.0- a version which replace use of full@metamask/controllersrepo with packages from@metamask/core-monorepo. This change allows us to reduce our unused code burden since@metamask/controllerswas bringing lots of code we don't currently use into our bundle (the controllers version ofKeyringController, with many additional dependencies, as one example).Bundle size reduced by .8MB :
This change should entail no functional changes.