UX: Fix token image not displaying in asset listing #17575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
darkwing
commented
Feb 2, 2023
| @@ -93,6 +97,10 @@ export default class Identicon extends Component { | |||
| src={image} | |||
| style={getStyles(diameter)} | |||
| alt={alt} | |||
| onError={() => { | |||
| this.setState({ imageLoadingError: true }); | |||
| this.forceUpdate(); | |||
There was a problem hiding this comment.
I absolutely loathe this but simply updating state doesn't cause a re-render
There was a problem hiding this comment.
TIL about forceUpdate
There was a problem hiding this comment.
The reason is because of the shouldComponentUpdate only compares props.
There was a problem hiding this comment.
the second prop to shouldComponentUpdate is nextState
dan437
previously approved these changes
Feb 2, 2023
darkwing
force-pushed
the
fix-asset-list-image
branch
from
8396749
to
d1ad653
Compare
darkwing
force-pushed
the
fix-asset-list-image
branch
from
d1ad653
to
48c8365
Compare
georgewrmarshall
previously approved these changes
Feb 2, 2023
Builds ready [48c8365]
Page Load Metrics (1269 ± 103 ms)
Bundle size diffs
|
dan437
previously approved these changes
Feb 3, 2023
brad-decker
requested changes
Feb 3, 2023
| @@ -93,6 +97,10 @@ export default class Identicon extends Component { | |||
| src={image} | |||
| style={getStyles(diameter)} | |||
| alt={alt} | |||
| onError={() => { | |||
| this.setState({ imageLoadingError: true }); | |||
| this.forceUpdate(); | |||
There was a problem hiding this comment.
The reason is because of the shouldComponentUpdate only compares props.
| @@ -93,6 +97,10 @@ export default class Identicon extends Component { | |||
| src={image} | |||
| style={getStyles(diameter)} | |||
| alt={alt} | |||
| onError={() => { | |||
| this.setState({ imageLoadingError: true }); | |||
| this.forceUpdate(); | |||
There was a problem hiding this comment.
the second prop to shouldComponentUpdate is nextState
darkwing
dismissed stale reviews from dan437 and georgewrmarshall
via
1c2fa08
Builds ready [1c2fa08]
Page Load Metrics (1281 ± 114 ms)
Bundle size diffs
|
brad-decker
approved these changes
Feb 3, 2023
georgewrmarshall
approved these changes
Feb 6, 2023
NidhiKJha
approved these changes
Feb 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
Tokens that we do have icons for sometimes don't display that icon in the token listing -- instead, a JazzIcon or Blockie displays. When clicking into the token's detail screen, the correct image does display. We weren't taking advantage of the image being passed in, which I've fixed.
One side effect of fixing the original problem is that a token for which we don't have an icon for shows a 404 icon, which is a problem. I've fixed this by showing a JazzIcon or Blockie if the image errors.
Screenshots/Screencaps
Manual Testing Steps
0xe4fae3faa8300810c835970b9187c268f55d998fPre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.