Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for hovering any Address parsed on Signed Type Data screen does not display the pointer anymore #18046

Merged
merged 5 commits into from
Mar 23, 2023

Conversation

aleksandar-mihajlovic
Copy link
Contributor

@aleksandar-mihajlovic aleksandar-mihajlovic commented Mar 8, 2023

Explanation

Added fix, so now when hovering over address on Signed Type Data screen cursor pointer shows up.

Screenshot

Before

signTypeDataBug

After

signTypeDataFix

Unit tests

Screenshot 2023-03-07 at 11 43 58

Lint

Screenshot 2023-03-08 at 11 51 40

Manual Testing Steps

  1. Go to Test Dapp https://metamask.github.io/test-dapp/
  2. Connect MetaMask
  3. Click to any Sign type data (Sign Type Data V4 is easiest to see)
  4. Hover any address -- see mouse pointer is now shown

@github-actions
Copy link
Contributor

github-actions bot commented Mar 8, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [b1f05cf]
Page Load Metrics (1603 ± 70 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint104178126188
domContentLoaded12961827157213665
load12961930160314570
domInteractive12961827157213665
Bundle size diffs
  • background: 0 bytes
  • ui: 21 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #18046 (56c9ac6) into develop (bf06598) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop   #18046   +/-   ##
========================================
  Coverage    63.86%   63.86%           
========================================
  Files          908      908           
  Lines        35391    35391           
  Branches      8966     8966           
========================================
  Hits         22600    22600           
  Misses       12791    12791           
Impacted Files Coverage Δ
...g/components/decoding/address/address.component.js 61.29% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dzfjz
Copy link
Contributor

dzfjz commented Mar 8, 2023

Verified by QA

@aleksandar-mihajlovic aleksandar-mihajlovic marked this pull request as ready for review March 8, 2023 13:30
@aleksandar-mihajlovic aleksandar-mihajlovic requested a review from a team as a code owner March 8, 2023 13:30
@seaona
Copy link
Contributor

seaona commented Mar 8, 2023

Looks good from QA

jpuri
jpuri previously approved these changes Mar 8, 2023
# Conflicts:
#	ui/components/app/signature-request/__snapshots__/signature-request.component.test.js.snap
@metamaskbot
Copy link
Collaborator

Builds ready [56c9ac6]
Page Load Metrics (1534 ± 41 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1042471283617
domContentLoaded1297170015148641
load1297170015348641
domInteractive1297170015148641
Bundle size diffs
  • background: 0 bytes
  • ui: 21 bytes
  • common: 0 bytes

@bschorchit bschorchit requested a review from jpuri March 15, 2023 15:06
@danjm danjm merged commit 8c310a0 into develop Mar 23, 2023
@danjm danjm deleted the signed-type-data-pointer-fix branch March 23, 2023 10:35
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Hovering any Address parsed on Signed Type Data screen does not display the pointer anymore
8 participants