Fix switch-ethereum-chain handler by passing configuration id to setA… #18483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [a81dff7]
Page Load Metrics (1707 ± 87 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
Codecov Report
@@ Coverage Diff @@
## develop #18483 +/- ##
========================================
Coverage 65.15% 65.15%
========================================
Files 936 936
Lines 35965 35965
Branches 9231 9231
========================================
Hits 23432 23432
Misses 12533 12533
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
legobeat
reviewed
Apr 6, 2023
legobeat
reviewed
Apr 6, 2023
| @@ -115,7 +115,7 @@ async function switchEthereumChainHandler( | |||
| ) { | |||
| setProviderType(approvedRequestData.type); | |||
| } else { | |||
| await setActiveNetwork(approvedRequestData); | |||
| await setActiveNetwork(approvedRequestData.id); | |||
There was a problem hiding this comment.
Codecov says Added line #L118 was not covered by tests but it looks like it should be covered looking at the test. Is it just codecov who doesn't handle e2e here?
There was a problem hiding this comment.
yeah, codecov can't measure e2e tests
pedronfigueiredo
previously approved these changes
Apr 6, 2023
Builds ready [d426fc7]
Page Load Metrics (1460 ± 31 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
reviewed
Apr 6, 2023
Builds ready [8e6eb11]
Page Load Metrics (1719 ± 67 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
DDDDDanica
previously approved these changes
Apr 6, 2023
Co-authored-by: legobeat <109787230+legobeat@users.noreply.github.com>
DDDDDanica
previously approved these changes
Apr 6, 2023
This reverts commit be533ff.
|
reverted the last commit because it broke lint (no arrow functions in |
DDDDDanica
approved these changes
Apr 6, 2023
Builds ready [90bf073]
Page Load Metrics (1666 ± 61 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
pedronfigueiredo
approved these changes
Apr 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18453
Explanation
In a previous commit, we updated
setActiveNetworkin the network controller to receive a network configuration id instead of a whole network object. However, the parameter passed tosetActiveNetworkin theswitch-ethereum-chain.jshandler was still passed the object, not the id. See 23ca4460cf#diff-93f17dab5026baf840aec766ac5b6ebcd35d5bb0abb45e2c3f41791423f2a488R117This PR corrects that, and adds an e2e test for the
wallet_switchEthereumChainfunctionality, which would have caught this bug.It is worth noting that the bug this PR fixes would not occur if you switched to the network immediately after adding it, because the correct parameter is passed to the
setActiveNetworkcall inadd-ethereum-chain.jswhich happens after prompting the user to switch networks (23ca4460cf#diff-b3485a1ea9943fd380364f73a53295289f2ccd3817423d4f245b5102f8620b3cR170)Manual Testing Steps
$(yarn bin ganache) --port 8546 --chain.chainId 1338Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Boardlabel.In this case, a QA Engineer approval will be be required.