Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding notification 18 title #18526

Merged
merged 2 commits into from
Apr 11, 2023
Merged

adding notification 18 title #18526

merged 2 commits into from
Apr 11, 2023

Conversation

vthomas13
Copy link
Contributor

Explanation

The changes from #18460 caused the title of the first What's New announcement to disappear. This changeset adds it back

Screenshots/Screencaps

Before

image

After

image

Manual Testing Steps

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [cd50cdb]
Page Load Metrics (1604 ± 33 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint942621173517
domContentLoaded1449174415817235
load1470176416046933
domInteractive1449174415817234
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@danjm danjm marked this pull request as ready for review April 10, 2023 22:27
@danjm danjm requested a review from a team as a code owner April 10, 2023 22:27
@danjm danjm requested a review from mcmire April 10, 2023 22:27
@metamaskbot
Copy link
Collaborator

Builds ready [795e6b9]
Page Load Metrics (1713 ± 53 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint923131285526
domContentLoaded15661950170911154
load15661950171311053
domInteractive15661950170911153
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vthomas13 vthomas13 merged commit 0b1354e into develop Apr 11, 2023
@vthomas13 vthomas13 deleted the whats-new-textfix branch April 11, 2023 11:46
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
@PeterYinusa PeterYinusa added the release-10.29.0 Issue or pull request that will be included in release 10.29.0 label Apr 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
rc-cherry-picked release-10.29.0 Issue or pull request that will be included in release 10.29.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants