fix(18709): fix error when switching to linea testnet using wallet_sw…

[VGau]

Explanation

Fixed the error when we use the MM API wallet_switchEthereumChain endpoint to switch to linea testnet network.

A new condition has been added in app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js file in findExistingNetwork function.

• Fixes [Bug]: Cannot switch to linea testnet network using "wallet_switchEthereumChain" #18709

Screenshots/Screencaps

Before

After

Manual Testing Steps

• Open this website : https://testnet.cashmere.exchange/swap
• Connect your metamask wallet.
• Select the Linea zkEVM testnet in the from dropdown.
• Click on the Switch network button at the bottom of the page.
• Check if the network switching worked

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[mcmire]

This error message is coming from a change we made recently where we moved custom networks from PreferencesController to NetworkController: #17421

I'm trying to understand why this bug exists. Is Linea testnet a network we regard as "built-in", or is something that users need to add themselves?

[VGau]

This error message is coming from a change we made recently where we moved custom networks from PreferencesController to NetworkController: #17421

I'm trying to understand why this bug exists. Is Linea testnet a network we regard as "built-in", or is something that users need to add themselves?

This bug exits because we are not getting the network info using this function findNetworkConfigurationBy in this file app/scripts/lib/rpc-method-middleware/handlers/switch-ethereum-chain.js.

We regard Linea testnet as "built-in" as "Sepolia" and "Goerli". The difference is that we use the network type RPC for the linea testnet. That's why we need to use findNetworkConfigurationBy function to get the linea testnet information and then get the networkconfigurationId.

My PR fixed this issue :)

[Gudahtt]

I'm trying to understand why this bug exists. Is Linea testnet a network we regard as "built-in", or is something that users need to add themselves?

We regard Linea testnet as "built-in" as "Sepolia" and "Goerli". The difference is that we use the network type RPC for the linea testnet.

This conversation is highlighting why "built-in network" is not a great term 😅

We have this unfortunate split between certain built-in Infura networks and all other networks that affects how we interact with the network controller. Built-in Infura networks require calling setProviderType whereas other networks require using setActiveNetwork).

Ideally we'd remove this split at some point, but that's the purpose of these conditions that are being changed in this PR.

[danjm]

LGTM

[Gudahtt]

LGTM!