New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLASK] Expanded Snap authorship #18775
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
GuillaumeRx
force-pushed
the
gr/expanded-snap-authorship
branch
from
April 25, 2023 10:26
7393ce0
to
19414fc
Compare
Builds ready [08213b4]
Page Load Metrics (1781 ± 69 ms)
Bundle size diffs
|
GuillaumeRx
force-pushed
the
gr/expanded-snap-authorship
branch
from
April 25, 2023 12:56
08213b4
to
79a9fa5
Compare
Builds ready [79a9fa5]
Page Load Metrics (1503 ± 39 ms)
Bundle size diffs
|
eriknson
reviewed
Apr 25, 2023
david0xd
reviewed
Apr 25, 2023
FrederikBolding
requested changes
Apr 25, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase and move all new components to /snaps
david0xd
reviewed
Apr 25, 2023
david0xd
reviewed
Apr 25, 2023
david0xd
reviewed
Apr 25, 2023
GuillaumeRx
force-pushed
the
gr/expanded-snap-authorship
branch
from
April 25, 2023 15:26
04d21e1
to
a706af9
Compare
GuillaumeRx
force-pushed
the
gr/expanded-snap-authorship
branch
from
April 25, 2023 15:26
a706af9
to
e371428
Compare
FrederikBolding
previously approved these changes
Apr 25, 2023
david0xd
approved these changes
Apr 25, 2023
FrederikBolding
approved these changes
Apr 25, 2023
Builds ready [aebc9c8]
Page Load Metrics (1786 ± 96 ms)
Bundle size diffs
|
hmalik88
approved these changes
Apr 25, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds the ability for the
SnapAuthorship
component to expand and display more data. It also refactors the ViewSnap component to use theSnapAuthorship
expanded and adds aSnapVersion
component.Screenshots/Screencaps
Manual Testing Steps