Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLASK] Expanded Snap authorship #18775

Merged
merged 10 commits into from Apr 25, 2023
Merged

Conversation

GuillaumeRx
Copy link
Contributor

@GuillaumeRx GuillaumeRx commented Apr 24, 2023

Explanation

This PR adds the ability for the SnapAuthorship component to expand and display more data. It also refactors the ViewSnap component to use the SnapAuthorship expanded and adds a SnapVersion component.

Screenshots/Screencaps

image
image
image
image

Manual Testing Steps

  • Look at a snap in settings

@GuillaumeRx GuillaumeRx requested a review from a team as a code owner April 24, 2023 12:48
@GuillaumeRx GuillaumeRx requested a review from danjm April 24, 2023 12:48
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [08213b4]
Page Load Metrics (1781 ± 69 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1123541415024
domContentLoaded14882012174312660
load15102036178114369
domInteractive14882012174312660
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@metamaskbot
Copy link
Collaborator

Builds ready [79a9fa5]
Page Load Metrics (1503 ± 39 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint84139105136
domContentLoaded1375164014917134
load1377166315038139
domInteractive1375164014917134
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@eriknson eriknson self-requested a review April 25, 2023 13:24
Copy link
Member

@FrederikBolding FrederikBolding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase and move all new components to /snaps

@metamaskbot
Copy link
Collaborator

Builds ready [aebc9c8]
Page Load Metrics (1786 ± 96 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint100168132178
domContentLoaded14252098177019292
load14252185178619996
domInteractive14252098177019292
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@GuillaumeRx GuillaumeRx merged commit 6126c15 into develop Apr 25, 2023
47 checks passed
@GuillaumeRx GuillaumeRx deleted the gr/expanded-snap-authorship branch April 25, 2023 17:20
@github-actions github-actions bot locked and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Expanded snaps authorship component
6 participants