Deprecate u2f ledger live on chrome

[montelaidev]

Explanation

Changes:

• deprecates the use of U2F and Ledger Live on chrome
• adds whats new notification
• new migration to set the ledgerTransportType to webhid for all chrome users.

Screenshots/Screencaps

After

Pre-merge author checklist

• [ x] I've clearly explained:
  • [ x] What problem this PR is solving
  • [ x] How this problem was solved
  • [ x] How reviewers can test my changes
• [ x] Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [4207f3f]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1690 ± 71 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	97	152	122	16	8
		domContentLoaded	1470	1972	1671	137	66
		load	1471	2052	1690	149	71
		domInteractive	1470	1972	1671	137	66

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 bytes
• ui: -3336 bytes
• common: 168 bytes

[metamaskbot]

Builds ready [2fcc787]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1687 ± 69 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	151	124	13	6
		domContentLoaded	1493	1942	1652	113	54
		load	1493	2061	1687	144	69
		domInteractive	1493	1942	1652	113	54

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 bytes
• ui: -3336 bytes
• common: 168 bytes

[gantunesr]

LGTM. One question I had while reviewing is that is there any way the user can tell which transport option they're using before connecting the Ledger device?

[metamaskbot]

Builds ready [af74213]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1542 ± 41 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	98	141	112	14	7
		domContentLoaded	1367	1675	1523	71	34
		load	1367	1687	1542	85	41
		domInteractive	1367	1675	1523	71	34

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 bytes
• ui: -3336 bytes
• common: 168 bytes

[metamaskbot]

Builds ready [3cf0004]

• builds: chrome, firefox
• builds (beta): chrome, firefox
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1527 ± 33 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	90	152	109	15	7
		domContentLoaded	1418	1685	1519	70	34
		load	1427	1685	1527	69	33
		domInteractive	1418	1685	1519	70	34

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 bytes
• ui: -3336 bytes
• common: 168 bytes

[metamaskbot]

Builds ready [677b876]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1800 ± 78 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	111	171	132	18	9
		domContentLoaded	1567	2124	1778	152	73
		load	1567	2124	1800	163	78
		domInteractive	1567	2124	1778	152	73

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 bytes
• ui: -3336 bytes
• common: 168 bytes

[metamaskbot]

Builds ready [50e098b]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1732 ± 49 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	103	150	125	16	8
		domContentLoaded	1586	1886	1718	97	47
		load	1601	1886	1732	101	49
		domInteractive	1586	1886	1718	97	47

Bundle size diffs [🚨 Warning! Bundle size has increased!]

• background: 0 bytes
• ui: -3336 bytes
• common: 168 bytes

[plasmacorral]

Do we need to include app/scripts/migrations/066.test.js (or 66.js) since there are no longer options for the user to choose a transport type in either Firefox or Chrome?

[plasmacorral]

My earlier comment is only partially addressed for Chrome. If the user has selected "U2F" and takes the update we will automatically switch to webHID and they can sign with Ledger. However, See 09/08/2023 edit below If the user has selected "Ledger Live" (or U2F) as the preferred Ledger connection method in v10.32.0 and then takes this update they will be locked out of being able to use their Ledger device with MetaMask as the migration is not producing the results expected.

Any mention of Ledger Live or Ledger Live bridge should be removed. This would mean removing this pop-up:

as well as the option in the drop-down within the add hardware flow: EDITED: derivation path should NOT be removed from the add hardware flow.

Video of the user experience: https://recordit.co/p7EZjkibLz

UPDATED Steps:

1. Download and install older version, for this test I used v10.32
2. configure wallet and pair with Ledger PSD
3. change Settings>Advanced>preferred Ledger connection type to Ledger Live
4. Close MM
5. Download and install this branch
6. Reload extension from chrome://extensions/
7. Launch MM and unlock
8. go to test dapp and connect then attempt to sign v4 typed data
9. Note that Ledger Live prompt is opened and the user can no longer connect to the Ledger OR set webhid in settings

09/08/2023 update: able to produce this with u2f selected in v10.32.0 before updating to this branch, both locally built.

[plasmacorral]

If we have to make further changes, I will once again suggest that we also remove the search result in all browsers when the setting is removed. Although this is not a blocker here.

[metamaskbot]

Builds ready [ed29c0e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 12, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (1595 ± 44 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	115	180	134	16	8
		domContentLoaded	1458	1826	1594	91	44
		load	1458	1826	1595	91	44
		domInteractive	1458	1826	1594	91	44

Bundle size diffs [🚀 Bundle size reduced!]

• background: -406 Bytes (-0.01%)
• ui: -3.19 KiB (-0.04%)
• common: -241 Bytes (-0.01%)

[github-actions]

This PR has been automatically marked as stale because it has not had recent activity in the last 60 days. It will be closed in 14 days. Thank you for your contributions.

[metamaskbot]

Builds ready [0243a1e]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • inpage: inpage
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (480 ± 253 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	88	132	104	13	6
		domContentLoaded	72	125	93	12	6
		load	85	1356	480	527	253
		domInteractive	72	125	93	12	6

Bundle size diffs [🚀 Bundle size reduced!]

• background: -471 Bytes (-0.01%)
• ui: -3.19 KiB (-0.05%)
• common: -252 Bytes (-0.01%)

[plasmacorral]

Unable to repro observation initially shared here. In test today migrating from v10.32.0 to commit 0243a1e1cfbca3bd686df2d8729a7b9878594b5b and was able to observe migration 103 complete successfully for a user that had Ledger Live selected in 10.32. Able to sign with no issue. Confirmed w/ Mac Sonoma 14.0 and Chrome 117.0.5938.92.

[plasmacorral]

Tested migration from 10.32.0 to this branch in Chrome 117.0.5938.92. Also tested migration from 10.35.1 to this branch under throttled network speeds (slow 3G) in Chrome. Spot checked migration in Firefox with Trezor from 11.3.0 to this branch in Firefox 119.0.1.