Part of #17670: Replace Typography with Text component in: callout.js

[PrgrmrHarshShukla]

Explanation

This PR is a part of #17670 Replace Typography with Text component for:
ui\components\ui\callout\callout.js

Screenshots/Screencaps

Before

After

Manual Testing Steps

Pre-merge author checklist

• I've clearly explained:
  • What problem this PR is solving
  • How this problem was solved
  • How reviewers can test my changes
• Sufficient automated test coverage has been added

Pre-merge reviewer checklist

• Manual testing (e.g. pull and build branch, run in browser, test code being changed)
• PR is linked to the appropriate GitHub issue
• IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[georgewrmarshall]

Need to fix linting issue otherwise LGTM

[PrgrmrHarshShukla]

Hey @georgewrmarshall ,

I have added the test tokens from the test dApp.
One question / doubt,
these test actions do not cause any actual real charges?

[georgewrmarshall]

Hey @PrgrmrHarshShukla, just wanted to check in. It looks like this PR is almost there. Did you still want to work on it? If so, that's great! Let us know if you need any assistance or if there are any blockers. If you're unable to continue working on it or haven't had a chance to address it, no worries! I can take it from here and carry it forward. Cheers!

[PrgrmrHarshShukla]

Hey @georgewrmarshall ,
I am really sorry for the inconvenience caused.
I was not getting any emails of the comments on my PRs.

Also , due to an unknown issue, I was not able to get the extension running locally, so I was not able to take any screenshots.

I did not want to trouble you.
I tried to find the solution myself, but couldn't.

Now, I am going to fork this again and delete the old fork.
Will that work?

[georgewrmarshall]

Hey @PrgrmrHarshShukla, looks like you need to run yarn to install some missing dependencies. Could you also please re-sign the CLA?

[georgewrmarshall]

Hey @PrgrmrHarshShukla, thanks for all your effort with this PR I am going to close it as it has become stale. Please feel free to open another PR in future. Thanks for your contributions thus far!

[PrgrmrHarshShukla]

Hey @georgewrmarshall ,
Sorry for all the inconvenience caused.
Will try and fix the problem because of which I cannot run it locally.
Have not succeeded yet.
Until then I will not open any new PRs related to this issue as I would not be able to add the screenshots.🙏🏼

Equipped with all the experiences and learnings from the PRs till date,
I will be back with much better and organized PRs in the future.🙏🏼

Regards,
Harsh

[PrgrmrHarshShukla]

I have read and agree to the Contributor License Agreement (CLA).

[codecov]

Codecov Report

Merging #18912 (06a2453) into develop (bc2a5aa) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #18912      +/-   ##
===========================================
- Coverage    70.45%   70.45%   -0.01%     
===========================================
  Files          985      985              
  Lines        38370    38370              
  Branches     10047    10047              
===========================================
- Hits         27033    27031       -2     
- Misses       11337    11339       +2     

Impacted Files	Coverage Δ
ui/components/ui/callout/callout.js	61.11% <ø> (ø)

... and 2 files with indirect coverage changes

[georgewrmarshall]

LGTM!