Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused GitHub Action workflow #19660

Merged
merged 1 commit into from
Jun 26, 2023
Merged

Remove unused GitHub Action workflow #19660

merged 1 commit into from
Jun 26, 2023

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Jun 19, 2023 •
edited

Explanation

This GitHub action workflow was disabled, but was still running setup steps. It has now been removed entirely. We can re-introduce it again later once the problem that led to it being disabled has been fixed.

The associated npm script and JavaScript module have been removed as well.

Manual Testing Steps

N/A

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@Gudahtt Gudahtt marked this pull request as ready for review June 19, 2023 19:48
@Gudahtt Gudahtt requested a review from a team as a code owner June 19, 2023 19:48
@Gudahtt Gudahtt requested a review from mcmire June 19, 2023 19:48
@Gudahtt Gudahtt force-pushed the remove-unused-action-workflow branch 2 times, most recently from 1a18e9b to 52a6095 Compare June 19, 2023 20:12
@socket-security
Copy link

socket-security bot commented Jun 19, 2023 •
edited

👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Next steps

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of package-name@version specifiers. e.g. @SocketSecurity ignore foo@1.0.0 bar@* or ignore all packages with @SocketSecurity ignore-all

@socket-security
Copy link

socket-security bot commented Jun 19, 2023 •
edited

New and updated dependency changes detected. Learn more about Socket for GitHub ↗︎

@Gudahtt
Copy link
Member Author

Gudahtt commented Jun 19, 2023

@SocketSecurity ignore extension-port-stream@2.1.1

False positive; flagged version is not in the lockfile

@metamaskbot
Copy link
Collaborator

Builds ready [74d1f67]
Page Load Metrics (1892 ± 58 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1071801422110
domContentLoaded16682116185112761
load17062117189212158
domInteractive16682116185112761
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 19, 2023 •
edited

Codecov Report

Merging #19660 (74d1f67) into develop (6bb786f) will increase coverage by 0.66%.
The diff coverage is n/a.

❗ Current head 74d1f67 differs from pull request most recent head bd6f412. Consider uploading reports for the commit bd6f412 to get more accurate results

@@             Coverage Diff             @@
##           develop   #19660      +/-   ##
===========================================
+ Coverage    69.83%   70.49%   +0.66%     
===========================================
  Files          980      985       +5     
  Lines        36886    38428    +1542     
  Branches      9890    10063     +173     
===========================================
+ Hits         25757    27086    +1329     
- Misses       11129    11342     +213

see 60 files with indirect coverage changes

@Gudahtt Gudahtt force-pushed the remove-unused-action-workflow branch 3 times, most recently from d3ae18a to adc2bde Compare June 20, 2023 13:24
@metamaskbot
Copy link
Collaborator

Builds ready [adc2bde]
Page Load Metrics (1824 ± 63 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint108198142189
domContentLoaded15882048179711857
load15892048182413163
domInteractive15882048179711857
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@Gudahtt Gudahtt force-pushed the remove-unused-action-workflow branch from adc2bde to 9e2d72e Compare June 20, 2023 23:42
@metamaskbot
Copy link
Collaborator

Builds ready [9e2d72e]
Page Load Metrics (1457 ± 36 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint96150111136
domContentLoaded1257150514355527
load1257158714577536
domInteractive1257150514355527
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@Gudahtt Gudahtt force-pushed the remove-unused-action-workflow branch from 9e2d72e to e3d73c8 Compare June 21, 2023 11:59
@metamaskbot
Copy link
Collaborator

Builds ready [e3d73c8]
Page Load Metrics (1564 ± 49 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1043091465828
domContentLoaded1420179815459445
load14201798156410249
domInteractive1420179815459445
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@Gudahtt
Remove unused GitHub Action workflow
bd6f412 
This GitHub action workflow was disabled, but was still running setup
steps. It has now been removed entirely. We can re-introduce it again
later once the problem that led to it being disabled has been fixed.

The associated npm script and JavaScript module have been removed as
well.
@Gudahtt Gudahtt force-pushed the remove-unused-action-workflow branch from e3d73c8 to bd6f412 Compare June 26, 2023 11:36
@metamaskbot
Copy link
Collaborator

Builds ready [bd6f412]
Page Load Metrics (1418 ± 30 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint97153114157
domContentLoaded1321156614186230
load1321156614186230
domInteractive1321156614186230
Bundle size diffs
  • background: 0 bytes
  • ui: 0 bytes
  • common: 0 bytes

@Gudahtt Gudahtt merged commit 55a8ff2 into develop Jun 26, 2023
56 checks passed
@Gudahtt Gudahtt deleted the remove-unused-action-workflow branch June 26, 2023 14:20
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@darkwing darkwing darkwing approved these changes

@brad-decker brad-decker brad-decker approved these changes

@mcmire mcmire Awaiting requested review from mcmire mcmire is a code owner automatically assigned from MetaMask/extension-devs

Assignees
No one assigned
Labels
release-10.34.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Gudahtt @metamaskbot @darkwing @brad-decker