-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX: Ensure multichain native token name is always shown #19705
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [9dc0a44]
Page Load Metrics (1665 ± 68 ms)
Bundle size diffs
|
Codecov Report
@@ Coverage Diff @@
## develop #19705 +/- ##
===========================================
- Coverage 70.79% 70.79% -0.00%
===========================================
Files 988 988
Lines 38366 38362 -4
Branches 10042 10041 -1
===========================================
- Hits 27161 27157 -4
Misses 11205 11205
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks really good, thanks!
Explanation
This PR ensures that the native token name is displayed regardless of the Settings -> Primary currency value. Previously it was showing "USD" for Ethereum, which is confusing.
Screenshots/Screencaps
Before
After
Manual Testing Steps
Pre-merge author checklist
Pre-merge reviewer checklist
If further QA is required (e.g. new feature, complex testing steps, large refactor), add the
Extension QA Board
label.In this case, a QA Engineer approval will be be required.