Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Ensure multichain native token name is always shown #19705

Merged
merged 5 commits into from
Jun 26, 2023

Conversation

darkwing
Copy link
Contributor

Explanation

This PR ensures that the native token name is displayed regardless of the Settings -> Primary currency value. Previously it was showing "USD" for Ethereum, which is confusing.

Screenshots/Screencaps

Before

247115557-6cff3806-9310-406f-9a67-afd53b17f486

After

SCR-20230621-iwjw

Manual Testing Steps

  • Flip the settings for Primary currency between Fiat and ETH, see Ethereum shown as the native token in the token list
  • Switch to Polygon
  • Flip the settings for Primary currency between Fiat and MATIC, see MATIC shown as the native token in the token list

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@darkwing darkwing requested a review from a team as a code owner June 21, 2023 14:36
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [9dc0a44]
Page Load Metrics (1665 ± 68 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1001991332512
domContentLoaded14451919164214067
load14541932166514268
domInteractive14451919164214067
Bundle size diffs
  • background: 0 bytes
  • ui: -122 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 21, 2023

Codecov Report

Merging #19705 (9dc0a44) into develop (b7f8c82) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop   #19705      +/-   ##
===========================================
- Coverage    70.79%   70.79%   -0.00%     
===========================================
  Files          988      988              
  Lines        38366    38362       -4     
  Branches     10042    10041       -1     
===========================================
- Hits         27161    27157       -4     
  Misses       11205    11205              
Impacted Files Coverage Δ
ui/components/app/asset-list/asset-list.js 75.00% <50.00%> (-2.78%) ⬇️

Copy link
Member

@NidhiKJha NidhiKJha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks really good, thanks!

@darkwing darkwing merged commit 9a9625d into develop Jun 26, 2023
50 checks passed
@darkwing darkwing deleted the fix-token-name-usd branch June 26, 2023 17:54
@github-actions github-actions bot locked and limited conversation to collaborators Jun 26, 2023
@danjm danjm added release-blocker This bug is blocking the next release release-10.33.0 and removed release-10.34.0 labels Jun 27, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.33.0 release-blocker This bug is blocking the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants