Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed portfolio link from wallet view #19716

Merged
merged 5 commits into from
Jun 23, 2023
Merged

removed portfolio link from wallet view #19716

merged 5 commits into from
Jun 23, 2023

Conversation

NidhiKJha
Copy link
Member

This PR is to remove the portfolio link from Eth Overview

Screenshots/Screencaps

Before

Screenshot 2023-06-22 at 2 29 00 PM

After

Screenshot 2023-06-22 at 2 28 08 PM

Manual Testing Steps

  • Go to the home screen
  • In eth overview, no portfolio link should be there

Pre-merge author checklist

  • I've clearly explained:
    • What problem this PR is solving
    • How this problem was solved
    • How reviewers can test my changes
  • Sufficient automated test coverage has been added

Pre-merge reviewer checklist

  • Manual testing (e.g. pull and build branch, run in browser, test code being changed)
  • PR is linked to the appropriate GitHub issue
  • IF this PR fixes a bug in the release milestone, add this PR to the release milestone

If further QA is required (e.g. new feature, complex testing steps, large refactor), add the Extension QA Board label.

In this case, a QA Engineer approval will be be required.

@NidhiKJha NidhiKJha requested a review from a team as a code owner June 22, 2023 08:59
@NidhiKJha NidhiKJha added team-extension-client team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead labels Jun 22, 2023
albertolive
albertolive previously approved these changes Jun 22, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [0884134]
Page Load Metrics (1647 ± 52 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1012551313316
domContentLoaded1421178715928842
load14211913164710852
domInteractive1421178715928842
Bundle size diffs
  • background: 0 bytes
  • ui: -506 bytes
  • common: 0 bytes

@codecov
Copy link

codecov bot commented Jun 22, 2023

Codecov Report

Merging #19716 (0884134) into develop (ed702af) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop   #19716      +/-   ##
===========================================
+ Coverage    70.79%   70.80%   +0.01%     
===========================================
  Files          988      988              
  Lines        38366    38362       -4     
  Branches     10042    10042              
===========================================
  Hits         27161    27161              
+ Misses       11205    11201       -4     
Impacted Files Coverage Δ
ui/components/app/wallet-overview/eth-overview.js 70.67% <ø> (+3.58%) ⬆️

@danjm danjm added release-blocker This bug is blocking the next release release-10.33.0 labels Jun 22, 2023
Copy link
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@NidhiKJha NidhiKJha merged commit dfb830e into develop Jun 23, 2023
52 checks passed
@NidhiKJha NidhiKJha deleted the fix-839 branch June 23, 2023 11:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-10.33.0 release-blocker This bug is blocking the next release team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants