Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #21169 - Ensure Copy format is plain text #21387

Merged
merged 2 commits into from
Oct 17, 2023
Merged

Fix #21169 - Ensure Copy format is plain text #21387

merged 2 commits into from
Oct 17, 2023

Conversation

darkwing
Copy link
Contributor

Description

After doing some research, our usage of copy-to-clipboard uses the default options, one of which is format that defaults to text/html. Since we only want the address copied, we should use the text/plain format.

Manual testing steps

  1. Click any "copy to clipboard" button.
  2. Ensure the output is plain text and not html

Related issues

Fixes #21169

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained:
    • What problem this PR is solving.
    • How this problem was solved.
    • How reviewers can test my changes.
  • I’ve indicated what issue this PR is linked to: Fixes #???
  • I’ve included tests if applicable.
  • I’ve documented any added code.
  • I’ve applied the right labels on the PR (see labeling guidelines).
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@darkwing darkwing requested a review from a team as a code owner October 16, 2023 14:55
@github-actions
Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

vthomas13
vthomas13 previously approved these changes Oct 16, 2023
Copy link
Contributor

@vthomas13 vthomas13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find

@garrettbear
Copy link
Contributor

Working for me, looks like some tests just need to quickly be updated

@darkwing darkwing added team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead needs-ux-ds-review labels Oct 16, 2023
@metamaskbot
Copy link
Collaborator

Builds ready [2de8f11]
Page Load Metrics (1366 ± 350 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint88136104147
domContentLoaded7213697157
load8319261366729350
domInteractive7213697157
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 1.32 KiB (0.02%)
  • common: 0 Bytes (0.00%)

@darkwing darkwing merged commit 98e77b8 into develop Oct 17, 2023
63 of 64 checks passed
@darkwing darkwing deleted the copy-format branch October 17, 2023 14:57
@github-actions github-actions bot locked and limited conversation to collaborators Oct 17, 2023
@metamaskbot metamaskbot added the release-11.5.0 Issue or pull request that will be included in release 11.5.0 label Oct 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
release-11.5.0 Issue or pull request that will be included in release 11.5.0 team-extension-ux DEPRECATED: please use "team-wallet-ux" label instead
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Clipboard widget copies formatted text
7 participants