New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UX Multichain: Updated app header account picker and address button #22637
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NidhiKJha
added
team-extension-client
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
labels
Jan 23, 2024
darkwing
requested changes
Jan 23, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few requests/suggestions:
- Can we make the entire address a
button
so that I can click the shorten address and get the copy functionality as well? - I think I added a
showAddress
prop to theAccountPicker
; is that still needed with these changes? (I guess maybe send flow?) - Is there a way we can better center the address? The
0x
pops out on the left, but the buttons line up on the right. Just a thought.
Builds ready [0c20608]
Page Load Metrics (757 ± 19 ms)
Bundle size diffs
|
Updated here cbaef93 |
vthomas13
previously approved these changes
Jan 31, 2024
darkwing
requested changes
Jan 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds ready [e0bce92]
Page Load Metrics (815 ± 25 ms)
Bundle size diffs
|
darkwing
previously approved these changes
Feb 2, 2024
NidhiKJha
force-pushed
the
header-updates-v1
branch
from
February 6, 2024 08:06
e0bce92
to
abd4ddf
Compare
Builds ready [f480ce1]
Page Load Metrics (825 ± 33 ms)
Bundle size diffs
|
darkwing
approved these changes
Feb 7, 2024
darkwing
added
the
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
label
Feb 7, 2024
vthomas13
approved these changes
Feb 8, 2024
metamaskbot
added
the
release-11.12.0
Issue or pull request that will be included in release 11.12.0
label
Feb 8, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
INVALID-PR-TEMPLATE
PR's body doesn't match template
needs-assets-ux-review
A shared label between the Assets and UX team to flag PRs ready for consolidated team review.
release-11.12.0
Issue or pull request that will be included in release 11.12.0
team-extension-ux
DEPRECATED: please use "team-wallet-ux" label instead
team-wallet-ux
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to update the following changes in App-Header:
Related issues
Fixes: 1816
Manual testing steps
MULTICHAIN=1 yarn start
Screenshots/Recordings
Before
After
Full Screen
Extension View
Pre-merge author checklist
Pre-merge reviewer checklist