-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
useDisplayName Hook and Integration into <Name/> Component #22734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [a6c7e8c]
Page Load Metrics (757 ± 18 ms)
Bundle size diffs
|
brad-decker
approved these changes
Jan 31, 2024
matthewwalsh0
approved these changes
Jan 31, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
QA Passed
release-11.11.0
Issue or pull request that will be included in release 11.11.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a new
useDisplayName
hook, aimed at including logic for displaying token names within the<Name/>
component. This hook replicates existing display logic, before Petnames.Details
Development of
useDisplayName
HookuseDisplayName
hook encapsulates the existing logic for determining a token's displayName. It performs sequential checks for:Integration with
<Name/>
ComponentReplacement of Logic: The existing
useName
logic within the<Name/>
component is replaced by theuseDisplayName
hook.Icon Display: The component adjusts the displayed icon (either a bookmark or a warning sign) based on the presence or absence of a resolved name.
Related issues
Fixes: #22735
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist