-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: [Snaps E2E] Create E2E test for UI links #22739
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [97744ec]
Page Load Metrics (1878 ± 67 ms)
Bundle size diffs
|
Builds ready [6b085be]
Page Load Metrics (1856 ± 83 ms)
Bundle size diffs
|
}); | ||
|
||
// wait for and click back button | ||
await driver.waitForSelector({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we not test that it opens the window?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're questioning testing that the dialog with the URL from the link, that is done from 92-95 as it is detecting that the correct address comes up before backing out of the modal to the approve button.
Are you suggesting that we click through to make sure that opening a new tab with the intended link also works?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added in the latest commit. It required adding hosts to the privacy snapshot but it works.
Builds ready [1c3becf]
Page Load Metrics (1079 ± 424 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #22739 +/- ##
========================================
Coverage 68.72% 68.72%
========================================
Files 1105 1105
Lines 43248 43248
Branches 11561 11561
========================================
Hits 29718 29718
Misses 13530 13530 ☔ View full report in Codecov by Sentry. |
Description
Create E2E test for UI links
Related issues
Fixes: #22425
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist