fix: push the menu up if there isn't enough space at the bottom

[montelaidev]

Description

This pr fixes the issue where the remove account menu option is cut off if there isn't enough screen space.

Related issues

Fixes: 22836

Manual testing steps

Pop-up view:

1. Create 3 HD accounts for a total of 4
2. Add 1 imported account
3. Click on the account menu
4. Click on 3 dots next to imported account
5. See that remove button is visible
6. Click to remove and then confirm
7. Ensure removed account is no longer in the accounts drop-down list

Full screen view:

1. Create 3 HD accounts for a total of 4
2. Add 1 imported account
3. From 3 dots menu open extension in expanded view
4. Click on the accounts menu
5. Click on 3 dots next to imported account
6. See that remove button is visible
7. Click to remove and then confirm
8. Ensure removed account is no longer in the accounts drop-down list

Hidden Account in pop-up view:

1. Create 3 HD accounts for a total of 4
2. Add 1 imported account
3. Click on the accounts menu
4. Click on 3 dots next to imported account
5. Select Hide account
6. From accounts menu, expand Hidden accounts
7. Click on 3 dots next to the hidden imported account
8. Make sure that remove is still presented and available
9. Click to remove and then confirm
10. Ensure removed account is no longer in the accounts drop-down list

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

[github-actions]

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

[metamaskbot]

Builds ready [6d5d37d]

• builds: chrome, firefox
• builds (beta): chrome
• builds (flask): chrome, firefox
• builds (MMI): chrome, firefox
• builds (test): chrome, firefox
• builds (test-flask): chrome, firefox
• build viz: Build System
• mv3: Background Module Init Stats
• mv3: UI Init Stats
• mv3: Module Load Stats
• mv3: Bundle Size Stats
• mv2: E2e Actions Stats
• code coverage: Report
• storybook: Storybook
• typescript migration: Dashboard
• all artifacts
• bundle viz:

  • background: 0, 1, 2, 3, 4
  • common: 0, 1, 2, 3, 4, 5, 6, 7
  • content-script: 0
  • contentscript: contentscript
  • disable-console: disable-console
  • policy-load: policy-load
  • sentry-install: sentry-install
  • ui: 0, 1, 10, 11, 2, 3, 4, 5, 6, 7, 8, 9

Page Load Metrics (838 ± 39 ms)

Platform	Page	Metric	Min (ms)	Max (ms)	Average (ms)	StandardDeviation (ms)	MarginOfError (ms)
Chrome	Home	firstPaint	84	144	112	18	9
		domContentLoaded	11	55	22	11	5
		load	733	1091	838	82	39
		domInteractive	11	55	22	11	6

Bundle size diffs

• background: 0 Bytes (0.00%)
• ui: 8 Bytes (0.00%)
• common: 0 Bytes (0.00%)

[darkwing]

Wonderful! Looks and functions great!

[plasmacorral]

Updated manual testing scenarios to cover pop-up view, expanded view, and removing a hidden account