Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: Show same balance on eth overview and account list item #23059

Merged
merged 6 commits into from Feb 21, 2024

Conversation

NidhiKJha
Copy link
Member

@NidhiKJha NidhiKJha commented Feb 20, 2024

This PR is to ensure total balance shows up for both eth overview and account list item

Related issues

Fixes: #23058

Manual testing steps

  1. Go to Eth Overview section, on a non test network. Look at the eth overview balance
  2. Account list item should show same balance as eth overview
  3. Total balance logic works only for NON-TEST Networks

Screenshots/Recordings

Before

Screen.Recording.2024-02-19.at.7.27.49.PM.mov

After

Screen.Recording.2024-02-20.at.9.41.21.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@NidhiKJha NidhiKJha added team-wallet-ux needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. labels Feb 20, 2024
@NidhiKJha NidhiKJha requested a review from a team as a code owner February 20, 2024 08:25
@metamaskbot metamaskbot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Feb 20, 2024
@metamaskbot
Copy link
Collaborator

Builds ready [175e87b]
Page Load Metrics (1052 ± 54 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1213122185325
domContentLoaded1094422713
load8101341105211254
domInteractive1094422713
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 0 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link

codecov bot commented Feb 20, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (ef9e63a) 68.48% compared to head (13d5ba6) 68.48%.
Report is 8 commits behind head on develop.

Files Patch % Lines
ui/components/app/wallet-overview/eth-overview.js 71.43% 2 Missing ⚠️
.../multichain/account-list-item/account-list-item.js 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #23059      +/-   ##
===========================================
+ Coverage    68.48%   68.48%   +0.01%     
===========================================
  Files         1089     1089              
  Lines        43015    43025      +10     
  Branches     11462    11465       +3     
===========================================
+ Hits         29455    29464       +9     
- Misses       13560    13561       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@metamaskbot
Copy link
Collaborator

Builds ready [4beea29]
Page Load Metrics (1127 ± 60 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint1082661984120
domContentLoaded1593482411
load8691373112712460
domInteractive1593482411
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 232 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

Copy link
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@metamaskbot
Copy link
Collaborator

Builds ready [13d5ba6]
Page Load Metrics (1091 ± 146 ms)
PlatformPageMetricMin (ms)Max (ms)Average (ms)StandardDeviation (ms)MarginOfError (ms)
ChromeHomefirstPaint963571905929
domContentLoaded9219424823
load81723191091305146
domInteractive8219424823
Bundle size diffs
  • background: 0 Bytes (0.00%)
  • ui: 232 Bytes (0.00%)
  • common: 0 Bytes (0.00%)

@NidhiKJha NidhiKJha merged commit cb14ec5 into develop Feb 21, 2024
66 checks passed
@NidhiKJha NidhiKJha deleted the show-total-balance branch February 21, 2024 10:22
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2024
@metamaskbot metamaskbot added the release-11.12.0 Issue or pull request that will be included in release 11.12.0 label Feb 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
INVALID-PR-TEMPLATE PR's body doesn't match template needs-assets-ux-review A shared label between the Assets and UX team to flag PRs ready for consolidated team review. release-11.12.0 Issue or pull request that will be included in release 11.12.0 team-wallet-ux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Different balance shows up for Eth Overview and Account LIst Item
4 participants