-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: missing network images #23140
fix: missing network images #23140
Conversation
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Builds ready [f2dd396]
Page Load Metrics (1797 ± 55 ms)
Bundle size diffs [🚨 Warning! Bundle size has increased!]
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Missing release label release-11.10.1 on PR. Adding release label release-11.10.1 on PR and removing other release labels(release-11.13.0), as PR was cherry-picked in branch 11.10.1. |
Description
Fixes an issue where the image files for some networks were not present in the filesystem, causing metamask to crash when trying to load them. The affected chains were:
Related issues
Fixes: #23084
Manual testing steps
Add any of the 4 affected chains to metamask, and visit the settings -> networks page. should not crash.
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist