New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show default petnames for watched NFTs #23438
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewwalsh0
added
the
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
label
Mar 12, 2024
Store addresses in lowercase.
Fix unit test. Fix storybook.
matthewwalsh0
commented
Mar 13, 2024
Builds ready [0dc6096]
Page Load Metrics (1011 ± 408 ms)
Bundle size diffs
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #23438 +/- ##
===========================================
+ Coverage 68.73% 68.76% +0.03%
===========================================
Files 1124 1125 +1
Lines 43617 43655 +38
Branches 11674 11683 +9
===========================================
+ Hits 29976 30015 +39
+ Misses 13641 13640 -1 ☔ View full report in Codecov by Sentry. |
Builds ready [54bd93d]
Page Load Metrics (869 ± 468 ms)
Bundle size diffs
|
dbrans
approved these changes
Mar 14, 2024
vinistevam
approved these changes
Mar 15, 2024
metamaskbot
added
the
release-11.14.0
Issue or pull request that will be included in release 11.14.0
label
Mar 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
release-11.14.0
Issue or pull request that will be included in release 11.14.0
team-confirmations-system
DEPRECATED: please use "team-confirmations" label instead
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The petnames component displays default names in scenarios where the address can be partially trusted despite no petname being saved.
This is currently the case for MetaMask contracts and ERC-20 tokens from the static token list or those recognised by the remote token API.
This PR also shows default names and icons for any watched NFT contracts from any of the user's accounts on the current chain.
Related issues
Fixes: #2245
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist